linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] mfd: SM501 core driver
Date: Wed, 7 Feb 2007 06:24:15 -0800	[thread overview]
Message-ID: <20070207142415.GE1712@kroah.com> (raw)
In-Reply-To: <20070207114825.GA21120@fluff.org.uk>

On Wed, Feb 07, 2007 at 11:48:25AM +0000, Ben Dooks wrote:
> On Tue, Feb 06, 2007 at 09:09:30PM -0800, Andrew Morton wrote:
> > On Tue, 6 Feb 2007 19:26:28 +0000 Ben Dooks <ben-linux@fluff.org> wrote:
> > > +/* sm501_null_release
> > > + *
> > > + * A release function for the platform devices we create to keep the
> > > + * driver core happy, and stop any crashed when the devices are removed
> > > +*/
> > > +
> > > +static void sm501_null_release(struct device *dev)
> > > +{
> > > +}
> > 
> > Greg might have an opinion on that ;)
> 
> Without this the system OOPses when the driver is removed.

Are you sure about that?  And it's not just an error message being
printed out telling you that you must provide a release function?

And BIG hint, providing an empty release function just to shut up the
kernel is NOT a fix.  You really need to free your memory here, not just
ignore it.

thanks,

greg k-h

  reply	other threads:[~2007-02-07 14:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06 19:26 [PATCH] mfd: SM501 core driver Ben Dooks
2007-02-07  5:09 ` Andrew Morton
2007-02-07 11:48   ` Ben Dooks
2007-02-07 14:24     ` Greg KH [this message]
2007-02-07 15:29       ` Ben Dooks
2007-02-07 16:52     ` Andrew Morton
2007-02-07 17:09       ` Ben Dooks
2007-02-08 17:56         ` James Simmons
2007-02-12 11:12           ` [Linux-fbdev-devel] " Ben Dooks
2007-02-07 17:38   ` Vincent Sanders

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070207142415.GE1712@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=ben-linux@fluff.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).