Re: [PATCH 2.6.20] isdn-capi: Use ARRAY_SIZE macro when appropriate

From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: Philippe De Muyter <phdm@macqel.be>
Cc: Joe Perches <joe@perches.com>,
	kkeil@suse.de, kai.germaschewski@gmx.de,
	linux-kernel@vger.kernel.org, isdn4linux@listserv.isdn4linux.de
Subject: Re: [PATCH 2.6.20] isdn-capi: Use ARRAY_SIZE macro when appropriate
Date: Wed, 7 Feb 2007 21:41:00 +0200	[thread overview]
Message-ID: <20070207194059.GY8991@Ahmed> (raw)
In-Reply-To: <20070206211813.GD2649@ingate.macqel.be>

On Tue, Feb 06, 2007 at 10:18:14PM +0100, Philippe De Muyter wrote:
> On Tue, Feb 06, 2007 at 10:41:30PM +0200, Ahmed S. Darwish wrote:
> >  
> > -    for (i=nelem-1; i >= 0; i--) {
> > +    for (i = ARRAY_SIZE(procfsentries) - 1; i >= 0; i--) {
> 
> I would write such decrementing loops as :
> 
>        for (i = ARRAY_SIZE(procfsentries); --i >= 0; ) {
> 
> Long time ago, that produced better code.  I did not check recently though.
[...]
> > -    for (i=nelem-1; i >= 0; i--) {
> > +    for (i = ARRAY_SIZE(procfsentries) - 1; i >= 0; i--) {
> 
> Same here

Hi Philippe,

Won't this hurt readability ?. I'm not a gcc guru anyway to have an
opinion on such stuff :).

-- 
Ahmed S. Darwish
http://darwish-07.blogspot.com