From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030338AbXBORcn (ORCPT ); Thu, 15 Feb 2007 12:32:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030341AbXBORcn (ORCPT ); Thu, 15 Feb 2007 12:32:43 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:49563 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030338AbXBORcm (ORCPT ); Thu, 15 Feb 2007 12:32:42 -0500 Date: Thu, 15 Feb 2007 17:32:18 +0000 From: Christoph Hellwig To: Jeremy Fitzhardinge Cc: "Eric W. Biederman" , Andi Kleen , Andrew Morton , virtualization@lists.osdl.org, xen-devel@lists.xensource.com, Chris Wright , Ian Pratt , linux-kernel@vger.kernel.org Subject: Re: [patch 15/21] Xen-paravirt: Add Xen interface header files Message-ID: <20070215173218.GA6324@infradead.org> Mail-Followup-To: Christoph Hellwig , Jeremy Fitzhardinge , "Eric W. Biederman" , Andi Kleen , Andrew Morton , virtualization@lists.osdl.org, xen-devel@lists.xensource.com, Chris Wright , Ian Pratt , linux-kernel@vger.kernel.org References: <20070213221729.772002682@goop.org> <20070213221830.619562494@goop.org> <45D3A50A.9090303@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45D3A50A.9090303@goop.org> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 14, 2007 at 04:10:50PM -0800, Jeremy Fitzhardinge wrote: > Eric W. Biederman wrote: > > Jeremy Fitzhardinge writes: > > > > > >> Add Xen interface header files. These are taken fairly directly from > >> the Xen tree and hence the style is not entirely in accordance with > >> Linux guidelines. There is a tension between fitting with Linux coding > >> rules and ease of maintenance. > >> > >> Define macros and inline functions for doing hypercalls into the > >> hypervisor. > >> > >> Signed-off-by: Jeremy Fitzhardinge > >> Signed-off-by: Ian Pratt > >> Signed-off-by: Christian Limpach > >> Signed-off-by: Chris Wright > >> > >> > >> -- > >> include/asm-i386/hypercall.h | 416 +++++++++++++++++++++++++++++ > >> include/asm-i386/hypervisor.h | 72 +++++ > >> > > > > Are hypercall.h and hypervisor.h generic or are they Xen specific. > > If they are Xen specific (as it appears) then are inappropriately > > named. > > > > Thanks for the reminder; I've been meaning to move/rename these. > > >> include/xen/interface/arch-x86_32.h | 187 +++++++++++++ > >> > > Why isn't this file include-asm-i386/xen/arch-x86_32.h ? > > > > Those files are more or less directly copied from the Xen tree, and its > easier if they don't drift too far in name and directory structure. Nack, we don't put per-arch crap there. Either you'll have it in separate places, or you clean up the utterly braindead scheme in the Xen tree aswell.