From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933099AbXCEK6S (ORCPT ); Mon, 5 Mar 2007 05:58:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933082AbXCEK6S (ORCPT ); Mon, 5 Mar 2007 05:58:18 -0500 Received: from static-ip-62-75-166-246.inaddr.intergenia.de ([62.75.166.246]:39124 "EHLO vs166246.vserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933074AbXCEK6R (ORCPT ); Mon, 5 Mar 2007 05:58:17 -0500 From: Michael Buesch To: Adrian Bunk Subject: Re: 2.6.21-rc2-mm1: drivers/usb/host/ohci-ssb.c doesn't compile Date: Mon, 5 Mar 2007 11:57:16 +0100 User-Agent: KMail/1.9.5 Cc: Andrew Morton , linville@tuxdriver.com, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, dbrownell@users.sourceforge.net, greg@kroah.com, linux-usb-devel@lists.sourceforge.net References: <20070302030026.5eef0c92.akpm@linux-foundation.org> <20070305014728.GN3441@stusta.de> <200703051149.05664.mb@bu3sch.de> In-Reply-To: <200703051149.05664.mb@bu3sch.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200703051157.16822.mb@bu3sch.de> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Monday 05 March 2007 11:49, Michael Buesch wrote: > On Monday 05 March 2007 02:47, Adrian Bunk wrote: > > On Fri, Mar 02, 2007 at 03:00:26AM -0800, Andrew Morton wrote: > > >... > > > Changes since 2.6.20-mm2: > > >... > > > git-wireless.patch > > >... > > > git trees > > >... > > > > <-- snip --> > > > > ... > > CC drivers/usb/host/ohci-hcd.o > > In file included from > > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-hcd.c:931: > > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-ssb.c:47: error: request for member 'hcd_priv_size' in something not a structure or union > > Seems like there was a comma missing. > There also seems to be some Kconfig problem. will fix that. > > > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-ssb.c:47: error: 'ssb_ohci_device' undeclared here (not in a function) > > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-ssb.c:52: error: 'ssb_ohci_reset' undeclared here (not in a function) > > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-ssb.c:53: error: 'ssb_ohci_start' undeclared here (not in a function) > > ... > > make[4]: *** [drivers/usb/host/ohci-hcd.o] Error 1 > > > > <-- snip --> Actually, it seems like I will run into other kinds of nasty problems due to stupid design of the HCD code. The OHCI code #includes the various drivers, which have a module_init each. So if you compile PCI and SSB support, you have two module_init for one OHCI module. Not sure how to fix this. Any idea? -- Greetings Michael.