linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Greg KH <greg@kroah.com>
Cc: Michael Buesch <mb@bu3sch.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	linville@tuxdriver.com, linux-kernel@vger.kernel.org,
	linux-wireless@vger.kernel.org, dbrownell@users.sourceforge.net,
	linux-usb-devel@lists.sourceforge.net
Subject: Re: 2.6.21-rc2-mm1: drivers/usb/host/ohci-ssb.c doesn't compile
Date: Mon, 5 Mar 2007 19:37:02 +0100	[thread overview]
Message-ID: <20070305183702.GN3441@stusta.de> (raw)
In-Reply-To: <20070305182610.GA14113@kroah.com>

On Mon, Mar 05, 2007 at 10:26:10AM -0800, Greg KH wrote:
> On Mon, Mar 05, 2007 at 12:26:45PM +0100, Michael Buesch wrote:
> > On Monday 05 March 2007 11:57, Michael Buesch wrote:
> > > > >   CC      drivers/usb/host/ohci-hcd.o
> > > > > In file included from 
> > > > > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-hcd.c:931:
> > > > > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-ssb.c:47: error: request for member 'hcd_priv_size' in something not a structure or union
> > > > 
> > > > Seems like there was a comma missing.
> > > > There also seems to be some Kconfig problem. will fix that.
> > > > 
> > > > > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-ssb.c:47: error: 'ssb_ohci_device' undeclared here (not in a function)
> > > > > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-ssb.c:52: error: 'ssb_ohci_reset' undeclared here (not in a function)
> > > > > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-ssb.c:53: error: 'ssb_ohci_start' undeclared here (not in a function)
> > > > > ...
> > > > > make[4]: *** [drivers/usb/host/ohci-hcd.o] Error 1
> > > > > 
> > > > > <--  snip  -->
> > > 
> > > Actually, it seems like I will run into other kinds of nasty problems
> > > due to stupid design of the HCD code. The OHCI code #includes
> > > the various drivers, which have a module_init each. So if you
> > > compile PCI and SSB support, you have two module_init for one
> > > OHCI module. Not sure how to fix this. Any idea?
> > 
> > A real problem is that the HCD core seems to have the assumption
> > built-in that there can only be one OHCI driver per machine/arch.
> > That's not the case for SSB, where we can have both PCI and SSB
> > bus enabled, so both ohci drivers compiled.
> > Any idea? Greg perhaps?
> 
> David has provided hints on how to do this in the past on the
> linux-usb-devel list if I remember correctly.

Is there any good reason why we can't split the OHCI drivers properly 
into separate modules?

> thanks,
> 
> greg k-h

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2007-03-05 18:37 UTC|newest]

Thread overview: 129+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-02 11:00 2.6.21-rc2-mm1 Andrew Morton
2007-03-02 11:04 ` 2.6.21-rc2-mm1 Andrew Morton
2007-03-02 17:30   ` 2.6.21-rc2-mm1 Randy Dunlap
2007-03-04 11:58   ` [Re: 2.6.21-rc2-mm1] #error no ROMFS backing store interface configured Maciej Rutecki
2007-03-04 12:11     ` Andrew Morton
2007-03-04 15:11       ` Maciej Rutecki
2007-03-04 15:11     ` David Howells
2007-03-04 15:25       ` Adrian Bunk
2007-03-04 15:35       ` David Howells
2007-03-05  1:49         ` [-mm patch] fix the ROMFS_* dependencies Adrian Bunk
2007-03-05 13:36         ` David Howells
2007-03-06 23:43           ` Adrian Bunk
2007-03-02 11:04 ` 2.6.21-rc2-mm1 Russell King
2007-03-02 11:08   ` 2.6.21-rc2-mm1 Andrew Morton
2007-03-02 11:10     ` 2.6.21-rc2-mm1 Russell King
2007-03-02 11:15       ` 2.6.21-rc2-mm1 Andrew Morton
2007-03-03 18:03         ` 2.6.21-rc2-mm1 Russell King
2007-03-05 10:41           ` arm utrace Roland McGrath
2007-03-02 14:05 ` 2.6.21-rc2-mm1: EIP is at ext2_discard_reservation+0x1c/0x52 Alexey Dobriyan
2007-03-02 14:24 ` 2.6.21-rc2-mm1 Bryan Wu
2007-03-02 14:40 ` [-mm patch] cpu_idle: fix build break Frederik Deweerdt
2007-03-02 15:24   ` Venkatesh Pallipadi
2007-03-02 16:24     ` Frederik Deweerdt
2007-03-02 15:42 ` 2.6.21-rc2-mm1 - build error with HOTPLUG_CPU=N, CPU_IDLE=Y Valdis.Kletnieks
2007-03-02 15:56 ` 2.6.21-rc2-mm1 Michal Piotrowski
2007-03-05 10:14   ` 2.6.21-rc2-mm1 Andrew Morton
2007-03-05 10:30     ` 2.6.21-rc2-mm1 Antonino A. Daplas
2007-03-02 16:03 ` 2.6.21-rc2-mm1 - fb_ddc_read() not defined Valdis.Kletnieks
2007-03-02 16:31   ` James Simmons
2007-03-02 16:51     ` Valdis.Kletnieks
2007-03-02 16:19 ` [PATCH] longhaul pci_find_device -> pci_get_device conversion (was: Re: 2.6.21-rc2-mm1) Michal Piotrowski
     [not found]   ` <3888a5cd0703020945r4ca51f3dxe981050b817e7594@mail.gmail.com>
2007-03-02 18:10     ` Michal Piotrowski
2007-03-02 16:32 ` 2.6.21-rc2-mm1 Badari Pulavarty
2007-03-02 17:03   ` [patch -mm] x86_64: fake numa cmdline flag fix David Rientjes
2007-03-02 17:21     ` Badari Pulavarty
2007-03-02 17:10   ` 2.6.21-rc2-mm1 Andrew Morton
2007-03-02 17:15     ` 2.6.21-rc2-mm1 Badari Pulavarty
2007-03-02 21:12 ` 2.6.21-rc2-mm1: what about CONFIG_NO_HZ and !CONFIG_SMP ? Laurent Riffard
2007-03-02 20:57   ` Siddha, Suresh B
2007-03-02 22:09     ` Laurent Riffard
2007-03-02 22:52 ` 2.6.21-rc2-mm1: pata_via: wrong cable detection Laurent Riffard
2007-03-02 23:05 ` [PATCH -mm] char/epca.c remove unused function (was: Re: 2.6.21-rc2-mm1) Michal Piotrowski
2007-03-03  0:48   ` Alan Cox
2007-03-02 23:42 ` 2.6.21-rc2-mm1 Michal Piotrowski
2007-03-03  0:40   ` 2.6.21-rc2-mm1 Andrew Morton
2007-03-03  1:22     ` 2.6.21-rc2-mm1 Michal Piotrowski
2007-03-03  1:41       ` 2.6.21-rc2-mm1 Andrew Morton
2007-03-03 10:08         ` 2.6.21-rc2-mm1 Michal Piotrowski
2007-03-03 12:06           ` 2.6.21-rc2-mm1 Andrew Morton
2007-03-03  7:45 ` 2.6.21-rc2-mm1 - build error with CONFIG_NO_HZ=y and CONFIG_SMP=n Antonino A. Daplas
2007-03-03  7:59   ` Andrew Morton
2007-03-03 15:39 ` Keyboard stops working after *lock [Was: 2.6.21-rc2-mm1] Jiri Slaby
2007-03-03 15:54   ` Jiri Slaby
2007-03-03 17:41     ` Andrew Morton
2007-03-09 10:31       ` Jiri Slaby
2007-03-09 14:13         ` Dmitry Torokhov
2007-03-09 14:40           ` Jiri Kosina
2007-03-09 16:01             ` Jiri Kosina
2007-03-09 16:48               ` Jiri Slaby
2007-03-09 17:10                 ` Jiri Slaby
2007-03-11 21:39               ` Jiri Slaby
2007-03-11 21:47                 ` Jiri Kosina
2007-03-11 21:53                   ` Jiri Slaby
2007-03-11 22:11                     ` Jiri Slaby
2007-03-12  9:08                   ` Jiri Slaby
2007-03-12 15:09                     ` Alan Stern
2007-03-12 16:28                       ` Jiri Slaby
2007-03-12 19:56                         ` Alan Stern
2007-03-12 21:00                         ` Jiri Kosina
2007-03-12 22:32                           ` Jiri Slaby
2007-03-13 16:01                             ` Alan Stern
2007-03-13 16:13                               ` Jiri Slaby
2007-03-13 16:30                                 ` Alan Stern
2007-03-15 20:00                                 ` Alan Stern
2007-03-16 10:52                                   ` Jiri Slaby
2007-03-17 22:50                                   ` Jiri Slaby
2007-03-18  2:39                                     ` Alan Stern
2007-03-18  8:46                                       ` Jiri Slaby
2007-03-18 14:26                                         ` Alan Stern
2007-03-18 14:36                                           ` Jiri Slaby
2007-03-18 15:39                                             ` Alan Stern
2007-03-18 15:45                                               ` Jiri Slaby
2007-03-18 16:11                                                 ` Alan Stern
2007-03-04  9:07 ` 2.6.21-rc2-mm1 Mariusz Kozlowski
2007-03-04  9:48   ` 2.6.21-rc2-mm1 Mariusz Kozlowski
2007-03-04 11:34   ` 2.6.21-rc2-mm1 Andrew Morton
2007-03-04 12:01     ` 2.6.21-rc2-mm1 Mariusz Kozlowski
2007-03-04 17:06       ` 2.6.21-rc2-mm1 Mariusz Kozlowski
2007-03-04 17:13         ` 2.6.21-rc2-mm1 Michal Piotrowski
2007-03-04 17:20           ` 2.6.21-rc2-mm1 Michal Piotrowski
2007-03-05 16:34   ` 2.6.21-rc2-mm1 Zan Lynx
2007-03-05  0:11 ` 2.6.21-rc2-mm1 J.A. Magallón
2007-03-05  0:29   ` 2.6.21-rc2-mm1 Andrew Morton
2007-03-05  1:17   ` 2.6.21-rc2-mm1 Andrew Morton
2007-03-05  2:25     ` 2.6.21-rc2-mm1 Neil Brown
2007-03-05 15:42       ` 2.6.21-rc2-mm1 Bill Davidsen
2007-03-05  1:47 ` [-mm patch] saa7134: fix MODULES=n compilation Adrian Bunk
2007-03-05  1:47 ` 2.6.21-rc2-mm1: drivers/net/wireless/ compile error Adrian Bunk
2007-03-05 10:41   ` Michael Buesch
2007-03-05  1:47 ` 2.6.21-rc2-mm1: drivers/usb/host/ohci-ssb.c doesn't compile Adrian Bunk
2007-03-05 10:49   ` Michael Buesch
2007-03-05 10:57     ` Michael Buesch
2007-03-05 11:26       ` Michael Buesch
2007-03-05 18:26         ` Greg KH
2007-03-05 18:37           ` Adrian Bunk [this message]
2007-03-05 18:42         ` David Brownell
2007-03-05 19:09           ` Michael Buesch
2007-03-05  1:47 ` [-mm patch] arch/i386/kernel/vmi.c must #include <asm/kmap_types.h> Adrian Bunk
2007-03-05  2:57   ` Zachary Amsden
2007-03-05  1:47 ` [-mm patch] remove arch/i386/kernel/tsc.c:custom_sched_clock Adrian Bunk
2007-03-05  2:57   ` Zachary Amsden
2007-03-05  1:47 ` [-mm patch] make drivers/char/drm/drm_vm.c:drm_io_prot() static Adrian Bunk
2007-03-05  1:47 ` [-mm patch] drivers/cpuidle/: make code static Adrian Bunk
2007-03-05  1:49 ` [-mm patch] drivers/media/video/ivtv/: possible cleanups Adrian Bunk
2007-03-05  6:53   ` [v4l-dvb-maintainer] " Hans Verkuil
2007-03-05  1:49 ` [-mm patch] drivers/net/bonding/bond_main.c:make 3 functions static Adrian Bunk
2007-03-05  1:49 ` [-mm patch] make drivers/video/display/display-sysfs.c:display_class static Adrian Bunk
2007-03-05  1:49 ` [-mm patch] make fb_deferred_io_mkwrite() static Adrian Bunk
2007-03-05  1:49 ` [-mm patch] drivers/video/hecubafb.c: make 4 functions static Adrian Bunk
2007-03-05 22:20 ` 2.6.21-rc2-mm1 J.A. Magallón
2007-03-05 23:11   ` 2.6.21-rc2-mm1 Andrew Morton
2007-03-06  6:25     ` [PATCH] sched: fix idle at tick Con Kolivas
     [not found]       ` <20070305230240.9c2741d1.akpm@linux-foundation.org>
2007-03-06  7:41         ` Con Kolivas
2007-03-06  8:38           ` J.A. Magallón
2007-03-06  0:16 ` i2c vs nVidia [Re: 2.6.21-rc2-mm1] J.A. Magallón
2007-03-06  0:33   ` Andrew Morton
2007-03-06  0:44     ` Greg KH
2007-03-06  8:45       ` Jean Delvare
2007-03-06 10:56         ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070305183702.GN3441@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@linux-foundation.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).