From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Oleg Nesterov <oleg@tv-sign.ru>,
Anton Blanchard <anton@samba.org>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
Aneesh Kumar <aneesh.kumar@gmail.com>,
Srivatsa Vaddagiri <vatsa@in.ibm.com>,
Gautham R Shenoy <ego@in.ibm.com>
Subject: Re: [PATCH] kthread_should_stop_check_freeze (was: Re: [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread)
Date: Mon, 12 Mar 2007 23:39:06 +0100 [thread overview]
Message-ID: <20070312223906.GA9749@elf.ucw.cz> (raw)
In-Reply-To: <200703121219.12072.rjw@sisk.pl>
Hi!
> > > Looks good to me! The other kthread_should_stop() calls in
> > > rcutorture.c should also become
> > > kthread_should_top_check_freeze().
> > Why is it useful?
>
> Because we want to avoid repeating
>
> while (!kthread_should_stop()) {
> try_to_freeze();
> ...
> }
>
> in many places?
Do not do it, then. Confusion it causes is not worth saving one line
of code.
You do less typing, but the resulting code is _less_ readable, not
more.
NAK.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-03-12 22:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-26 7:00 [PATCH -mm 0/6] Freezer changes Rafael J. Wysocki
2007-02-26 7:02 ` [PATCH -mm 1/6] Freezer: Read PF_BORROWED_MM in a nonracy way Rafael J. Wysocki
2007-02-26 7:05 ` [PATCH -mm 2/6] Freezer: Fix memory ordering in refrigerator Rafael J. Wysocki
2007-02-26 11:32 ` Oleg Nesterov
2007-02-26 7:06 ` [PATCH -mm 3/6] Freezer: Close theoretical race between refrigerator and thaw_tasks Rafael J. Wysocki
2007-02-26 7:08 ` [PATCH -mm 4/6] Freezer: Remove PF_NOFREEZE from rcutorture thread Rafael J. Wysocki
2007-02-26 7:11 ` [PATCH -mm 5/6] Freezer: Remove PF_NOFREEZE from bluetooth threads Rafael J. Wysocki
2007-02-26 7:13 ` [PATCH -mm 6/6] Freezer: Add try_to_freeze calls to all kernel threads Rafael J. Wysocki
2007-03-01 15:05 ` [PATCH -mm 0/7] Freezer changes (take 2) Rafael J. Wysocki
2007-03-01 15:06 ` [PATCH -mm 1/7] Freezer: Read PF_BORROWED_MM in a nonracy way Rafael J. Wysocki
2007-03-01 15:08 ` [PATCH -mm 2/7] Freezer: Close theoretical race between refrigerator and thaw_tasks Rafael J. Wysocki
2007-03-01 16:39 ` Pavel Machek
2007-03-01 15:09 ` [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread Rafael J. Wysocki
2007-03-01 19:38 ` Anton Blanchard
2007-03-01 19:54 ` Rafael J. Wysocki
2007-03-02 21:35 ` Paul E. McKenney
2007-03-02 22:16 ` Anton Blanchard
2007-03-02 23:33 ` Oleg Nesterov
2007-03-03 0:58 ` Paul E. McKenney
2007-03-03 17:32 ` Oleg Nesterov
2007-03-04 4:34 ` Srivatsa Vaddagiri
2007-03-11 17:49 ` [PATCH] kthread_should_stop_check_freeze (was: Re: [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread) Rafael J. Wysocki
2007-03-12 4:38 ` Paul E. McKenney
2007-03-12 8:14 ` Pavel Machek
2007-03-12 11:19 ` Rafael J. Wysocki
2007-03-12 12:23 ` Oleg Nesterov
2007-03-12 13:24 ` [PATCH] kthread_should_stop_check_freeze Cedric Le Goater
2007-03-12 18:25 ` Rafael J. Wysocki
2007-03-12 22:39 ` Pavel Machek [this message]
2007-03-12 22:45 ` [PATCH] kthread_should_stop_check_freeze (was: Re: [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread) Anton Blanchard
2007-03-13 3:14 ` Srivatsa Vaddagiri
2007-03-13 9:16 ` Christoph Hellwig
2007-03-13 9:58 ` Srivatsa Vaddagiri
2007-03-13 10:20 ` Christoph Hellwig
2007-03-20 18:08 ` Pavel Machek
2007-03-13 0:58 ` Paul E. McKenney
2007-03-20 18:10 ` Pavel Machek
2007-03-13 5:27 ` Gautham R Shenoy
2007-03-13 5:42 ` Srivatsa Vaddagiri
2007-03-03 1:03 ` [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread Rafael J. Wysocki
2007-03-02 6:57 ` Gautham R Shenoy
2007-03-02 21:46 ` Paul E. McKenney
2007-03-01 15:10 ` [PATCH -mm 4/7] Freezer: Remove PF_NOFREEZE from bluetooth threads Rafael J. Wysocki
2007-03-01 15:12 ` [PATCH -mm 5/7] Freezer: Add try_to_freeze calls to all kernel threads Rafael J. Wysocki
2007-03-01 15:15 ` [PATCH -mm 6/7] Freezer: Fix vfork problem Rafael J. Wysocki
2007-03-01 15:17 ` [PATCH -mm 7/7] Freezer: Take kernel_execve into consideration Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070312223906.GA9749@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=aneesh.kumar@gmail.com \
--cc=anton@samba.org \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rjw@sisk.pl \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).