From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752314AbXCMKV2 (ORCPT ); Tue, 13 Mar 2007 06:21:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753204AbXCMKV2 (ORCPT ); Tue, 13 Mar 2007 06:21:28 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:35640 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933012AbXCMKV1 (ORCPT ); Tue, 13 Mar 2007 06:21:27 -0400 Date: Tue, 13 Mar 2007 10:20:43 +0000 From: Christoph Hellwig To: Srivatsa Vaddagiri Cc: Christoph Hellwig , Anton Blanchard , Pavel Machek , "Rafael J. Wysocki" , "Paul E. McKenney" , Oleg Nesterov , Andrew Morton , LKML , Aneesh Kumar , Gautham R Shenoy Subject: Re: [PATCH] kthread_should_stop_check_freeze (was: Re: [PATCH -mm 3/7] Freezer: Remove PF_NOFREEZE from rcutorture thread) Message-ID: <20070313102043.GA28835@infradead.org> Mail-Followup-To: Christoph Hellwig , Srivatsa Vaddagiri , Anton Blanchard , Pavel Machek , "Rafael J. Wysocki" , "Paul E. McKenney" , Oleg Nesterov , Andrew Morton , LKML , Aneesh Kumar , Gautham R Shenoy References: <200702260800.49603.rjw@sisk.pl> <20070312043854.GA4124@linux.vnet.ibm.com> <20070312081459.GI5242@elf.ucw.cz> <200703121219.12072.rjw@sisk.pl> <20070312223906.GA9749@elf.ucw.cz> <20070312224524.GB807@kryten> <20070313031411.GC9881@in.ibm.com> <20070313091629.GA19684@infradead.org> <20070313095808.GA19939@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070313095808.GA19939@in.ibm.com> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 13, 2007 at 03:28:08PM +0530, Srivatsa Vaddagiri wrote: > On Tue, Mar 13, 2007 at 09:16:29AM +0000, Christoph Hellwig wrote: > > > Document as well in the kernel_thread() API, as I notice people still > > > use kernel_thread() some places (ex: rtasd.c in powerpc arch)? > > > > They shouldn't use kernel_thread. > > Hmm ..that needs to be documented as well then! I can easily count more > than dozen places where kernel_thread() is being used. > > I agree though that kthread is a much cleaner interface to create/destroy > threads. Well, it takes a lot of time to convert all the existing users. But I try to make sure to flame^H^H^H^H^Hcorrect everyone who tries to sneak a new user of kernel_thread in.