From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933266AbXCMUz3 (ORCPT ); Tue, 13 Mar 2007 16:55:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933310AbXCMUz3 (ORCPT ); Tue, 13 Mar 2007 16:55:29 -0400 Received: from colin.muc.de ([193.149.48.1]:1602 "EHLO mail.muc.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933266AbXCMUz1 (ORCPT ); Tue, 13 Mar 2007 16:55:27 -0400 Date: 13 Mar 2007 21:55:26 +0100 Date: Tue, 13 Mar 2007 21:55:26 +0100 From: Andi Kleen To: Jeremy Fitzhardinge Cc: Rusty Russell , lkml - Kernel Mailing List Subject: Re: [PATCH] Introduce load_TLS to the "for" loop. Message-ID: <20070313205526.GA46469@muc.de> References: <1173767976.10618.50.camel@localhost.localdomain> <20070313135000.GA92373@muc.de> <45F6DFEF.2090008@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45F6DFEF.2090008@goop.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 13, 2007 at 10:31:27AM -0700, Jeremy Fitzhardinge wrote: > Andi Kleen wrote: > > On Tue, Mar 13, 2007 at 05:39:36PM +1100, Rusty Russell wrote: > > > >> GCC (4.1 at least) unrolls it anyway, but I can't believe this code > >> > > > > Are you sure? Normally it doesn't unroll without -funroll-loops which > > the kernel does normally not set. Especially not with -Os builds. > > > > Does it matter either way in this case? It's in the middle of the context switch. -Andi