From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240AbXCVHIn (ORCPT ); Thu, 22 Mar 2007 03:08:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753243AbXCVHIn (ORCPT ); Thu, 22 Mar 2007 03:08:43 -0400 Received: from mx2.go2.pl ([193.17.41.42]:55530 "EHLO poczta.o2.pl" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753240AbXCVHIm (ORCPT ); Thu, 22 Mar 2007 03:08:42 -0400 Date: Thu, 22 Mar 2007 08:13:14 +0100 From: Jarek Poplawski To: Andrew Morton Cc: Oleg Nesterov , Neil Brown , Peter Zijlstra , Folkert van Heusden , linux-kernel@vger.kernel.org, "J\. Bruce Fields" , Ingo Molnar Subject: Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2.6.20] BUG: workqueue leaked lock Message-ID: <20070322071314.GB2065@ff.dom.local> References: <17918.11420.155569.991473@notabene.brown> <20070320093753.GA1751@ff.dom.local> <20070320160759.GA107@tv-sign.ru> <20070321080510.GA1939@ff.dom.local> <20070321144620.GC78@tv-sign.ru> <20070321151651.GA4547@ff.dom.local> <20070321152935.GA215@tv-sign.ru> <20070321181635.GA570@tv-sign.ru> <20070322061119.GA1466@ff.dom.local> <20070321222802.0e09f0c2.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070321222802.0e09f0c2.akpm@linux-foundation.org> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 21, 2007 at 10:28:02PM -0800, Andrew Morton wrote: ... > I assume that some codepath is incrementing ->lockdep_depth even when > debug_locks==0. Isn't that wrong of it? > lockdep simply stops to update lockdep_depth just after (during) a bug or a WARN. Jarek P.