From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030274AbXCVJG5 (ORCPT ); Thu, 22 Mar 2007 05:06:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030278AbXCVJG5 (ORCPT ); Thu, 22 Mar 2007 05:06:57 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:42762 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030274AbXCVJG4 (ORCPT ); Thu, 22 Mar 2007 05:06:56 -0400 Date: Thu, 22 Mar 2007 10:06:32 +0100 From: Ingo Molnar To: Peter Zijlstra Cc: Jarek Poplawski , Oleg Nesterov , Neil Brown , Andrew Morton , Folkert van Heusden , linux-kernel@vger.kernel.org, "J. Bruce Fields" Subject: Re: [PATCH] lockdep: lockdep_depth vs. debug_locks Re: [2.6.20] BUG: workqueue leaked lock Message-ID: <20070322090632.GB15328@elte.hu> References: <17918.11420.155569.991473@notabene.brown> <20070320093753.GA1751@ff.dom.local> <20070320160759.GA107@tv-sign.ru> <20070321080510.GA1939@ff.dom.local> <20070321144620.GC78@tv-sign.ru> <20070321151651.GA4547@ff.dom.local> <20070321152935.GA215@tv-sign.ru> <20070321181635.GA570@tv-sign.ru> <20070322061119.GA1466@ff.dom.local> <1174548157.16411.4.camel@twins> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1174548157.16411.4.camel@twins> User-Agent: Mutt/1.4.2.2i X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.1.7 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > On Thu, 2007-03-22 at 07:11 +0100, Jarek Poplawski wrote: > > Here is some joke: > > > > [PATCH] lockdep: lockdep_depth vs. debug_locks > > > > lockdep really shouldn't be used when debug_locks == 0! > > This happens then lockdep reports a fatal error, at which point > it will stop tracking locks and leave whatever state was there. > > > Reported-by: Folkert van Heusden > > Inspired-by: Oleg Nesterov > > Signed-off-by: Jarek Poplawski > > This looks sane, thanks for figuring this out. > > Acked-by: Peter Zijlstra Acked-by: Ingo Molnar Ingo