From: Andrew Morton <akpm@linux-foundation.org>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: linux-kernel@vger.kernel.org, Mel Gorman <mel@csn.ul.ie>
Subject: Re: 2.6.22-rc4-mm2
Date: Thu, 7 Jun 2007 00:19:22 -0700 [thread overview]
Message-ID: <20070607001922.9f73902b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070607070513.GT6909@holomorphy.com>
On Thu, 7 Jun 2007 00:05:13 -0700 William Lee Irwin III <wli@holomorphy.com> wrote:
> On Thu, Jun 07, 2007 at 12:01:25AM -0700, Andrew Morton wrote:
> >> config, please?
>
> On Thu, Jun 07, 2007 at 12:04:07AM -0700, William Lee Irwin III wrote:
> > It's the sparc32 defconfig. Included below for completeness.
>
> The error output looks like the following.
>
>
> ERROR: "movable_zone" [fs/romfs/romfs.ko] undefined!
> ERROR: "movable_zone" [fs/isofs/isofs.ko] undefined!
> ERROR: "movable_zone" [fs/cifs/cifs.ko] undefined!
> ERROR: "movable_zone" [fs/afs/kafs.ko] undefined!
> ERROR: "movable_zone" [drivers/block/loop.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> make: *** Waiting for unfinished jobs....
> arch/sparc/mm/built-in.o: In function `kmap_atomic':
> (.text+0x433c): undefined reference to `movable_zone'
> arch/sparc/mm/built-in.o: In function `kmap_atomic':
> (.text+0x4348): undefined reference to `movable_zone'
> mm/built-in.o: In function `iov_iter_copy_from_user':
> (.text+0x770): undefined reference to `movable_zone'
> mm/built-in.o: In function `iov_iter_copy_from_user':
> (.text+0x844): undefined reference to `movable_zone'
> mm/built-in.o: In function `iov_iter_copy_from_user':
> (.text+0x850): undefined reference to `movable_zone'
> mm/built-in.o:(.text+0x870): more undefined references to `movable_zone' follow
> make[1]: *** [arch/sparc/boot/image] Error 1
hm, OK, this seems to work:
--- a/include/linux/mmzone.h~a
+++ a/include/linux/mmzone.h
@@ -541,10 +541,13 @@ static inline int populated_zone(struct
return (!!zone->present_pages);
}
+#ifdef CONFIG_ARCH_POPULATES_NODE_MAP
extern int movable_zone;
+#endif
+
static inline int zone_movable_is_highmem(void)
{
-#ifdef CONFIG_HIGHMEM
+#if defined(CONFIG_HIGHMEM) && defined(CONFIG_ARCH_POPULATES_NODE_MAP)
return movable_zone == ZONE_HIGHMEM;
#else
return 0;
_
(the first ifdef is just there to trip things at compile time rather than
link time)
next prev parent reply other threads:[~2007-06-07 7:19 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-07 5:03 2.6.22-rc4-mm2 Andrew Morton
2007-06-07 6:42 ` 2.6.22-rc4-mm2 William Lee Irwin III
2007-06-07 6:51 ` 2.6.22-rc4-mm2 Andrew Morton
2007-06-07 6:55 ` 2.6.22-rc4-mm2 William Lee Irwin III
2007-06-07 7:01 ` 2.6.22-rc4-mm2 Andrew Morton
2007-06-07 7:04 ` 2.6.22-rc4-mm2 William Lee Irwin III
2007-06-07 7:05 ` 2.6.22-rc4-mm2 William Lee Irwin III
2007-06-07 7:19 ` Andrew Morton [this message]
2007-06-07 7:34 ` 2.6.22-rc4-mm2 William Lee Irwin III
2007-06-07 7:11 ` 2.6.22-rc4-mm2 Paul Mundt
2007-06-07 9:19 ` 2.6.22-rc4-mm2 Manuel Lauss
2007-06-07 9:37 ` 2.6.22-rc4-mm2 Paul Mundt
2007-06-07 9:46 ` 2.6.22-rc4-mm2 Manuel Lauss
2007-06-07 20:01 ` 2.6.22-rc4-mm2 Adrian Bunk
2007-06-07 20:14 ` 2.6.22-rc4-mm2 Sam Ravnborg
2007-06-07 11:07 ` 2.6.22-rc4-mm2 Michal Piotrowski
2007-06-07 15:26 ` 2.6.22-rc4-mm2 Andrew Morton
2007-06-07 14:29 ` 2.6.22-rc4-mm2 Valdis.Kletnieks
2007-06-07 15:37 ` 2.6.22-rc4-mm2 - usb-storage Peter Zijlstra
2007-06-07 22:20 ` [usb-storage] " Alan Stern
2007-06-08 8:55 ` Peter Zijlstra
2007-06-08 14:16 ` Alan Stern
2007-06-08 16:30 ` Peter Zijlstra
2007-06-08 16:54 ` Alan Stern
2007-06-08 16:55 ` Peter Zijlstra
2007-06-14 22:47 ` Jeremy Fitzhardinge
2007-06-14 22:58 ` Peter Zijlstra
2007-06-14 23:20 ` Jeremy Fitzhardinge
2007-06-07 19:37 ` 2.6.22-rc4-mm2 Joseph Fannin
2007-06-07 20:31 ` 2.6.22-rc4-mm2 Andrew Morton
2007-06-07 21:46 ` 2.6.22-rc4-mm2: Assigning IP address fails Joseph Fannin
2007-06-07 22:06 ` Andrew Morton
2007-06-07 22:54 ` Herbert Xu
2007-06-08 1:35 ` David Miller
2007-06-12 0:07 ` 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n Adrian Bunk
2007-06-12 3:22 ` Dave Jones
2007-06-12 22:03 ` Andrew Morton
2007-06-12 22:16 ` Dave Jones
2007-06-12 22:43 ` Andrew Morton
2007-06-12 22:48 ` Dave Jones
2007-06-12 22:37 ` Adrian Bunk
2007-06-12 6:00 ` Avi Kivity
2007-06-12 11:07 ` [-mm patch] make cmdline_parse_kernelcore() static Adrian Bunk
2007-06-12 12:52 ` Mel Gorman
2007-06-12 11:07 ` [-mm patch] make mm/swap_prefetch.c:remove_from_swapped_list() static Adrian Bunk
2007-06-12 11:16 ` Con Kolivas
2007-06-12 23:03 ` [-mm patch] make drivers/acpi/osl.c:osi_linux static Adrian Bunk
2007-06-12 23:03 ` [-mm patch] drivers/acpi/processor_throttling.c: make 2 functions static Adrian Bunk
2007-06-12 23:03 ` [-mm patch] drivers/ata/sata_nv.c: make 3 " Adrian Bunk
2007-06-12 23:03 ` [-mm patch] make drivers/char/selection.c:store_utf8() static Adrian Bunk
2007-06-12 23:03 ` [-mm patch] drivers/cpuidle/governors/menu.c: make a struct static Adrian Bunk
2007-06-13 8:33 ` WARNING: at drivers/usb/core/urb.c:293 usb_submit_urb() [Was: 2.6.22-rc4-mm2] Jiri Slaby
2007-06-13 8:46 ` Jiri Slaby
2007-06-13 9:35 ` [Serial port bug?] was Re: 2.6.22-rc4-mm2 Reuben Farrelly
2007-06-14 22:15 ` [-mm patch] make fs/buffer.c:cont_expand_zero() static Adrian Bunk
2007-06-15 1:36 ` Nick Piggin
2007-06-14 22:15 ` [-mm patch] remove nobh_{prepare,commit}_write() Adrian Bunk
2007-06-26 20:32 ` Andrew Morton
2007-06-26 20:48 ` Dave Kleikamp
2007-06-26 21:23 ` Andrew Morton
2007-06-26 21:33 ` Randy Dunlap
2007-06-27 1:39 ` Nick Piggin
2007-06-14 22:15 ` [-mm patch] make fs/inode.c:wake_up_inode() static Adrian Bunk
2007-06-14 22:16 ` [-mm patch] make fs/libfs.c:simple_commit_write() static Adrian Bunk
2007-06-14 22:16 ` [-mm patch] fs/reiserfs/: cleanups Adrian Bunk
2007-06-15 1:37 ` Nick Piggin
2007-06-14 22:16 ` [-mm patch] make init/do_mounts.c:root_wait static Adrian Bunk
2007-06-14 22:16 ` [-mm patch] drivers/ide/ide-dma.c: unexport ide_set_dma Adrian Bunk
2007-06-16 0:18 ` Bartlomiej Zolnierkiewicz
2007-06-17 23:42 ` [-mm patch] arch/i386/video/fbdev.c should #include <asm/fb.h> Adrian Bunk
2007-06-18 4:52 ` Sam Ravnborg
2007-06-19 13:53 ` 2.6.22-rc4-mm2 J.A. Magallón
2007-06-19 14:34 ` 2.6.22-rc4-mm2 J.A. Magallón
2007-06-20 7:23 ` 2.6.22-rc4-mm2 Jiri Slaby
2007-06-20 21:54 ` 2.6.22-rc4-mm2 J.A. Magallón
2007-06-20 5:22 ` can't suspend on vaio sz (rc4 and rc5 are ok) [was Re: 2.6.22-rc4-mm2] Mattia Dongili
2007-06-20 11:40 ` Rafael J. Wysocki
2007-06-20 15:38 ` Mattia Dongili
2007-06-20 20:50 ` Rafael J. Wysocki
2007-06-20 22:03 ` Rafael J. Wysocki
2007-06-20 22:22 ` Rafael J. Wysocki
2007-06-21 15:28 ` Alan Stern
2007-06-21 19:39 ` Alan Stern
2007-06-21 21:49 ` Rafael J. Wysocki
2007-06-22 9:25 ` Mattia Dongili
2007-06-22 13:59 ` Alan Stern
2007-06-24 5:27 ` Mattia Dongili
2007-06-24 8:33 ` it's iwl3945 [Re: " Mattia Dongili
2007-06-20 14:01 ` [linux-usb-devel] " Alan Stern
2007-06-20 14:12 ` Rafael J. Wysocki
2007-06-21 23:52 ` [-mm patch] mark calibrate_xor_blocks() __init Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070607001922.9f73902b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).