From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761382AbXFQVvY (ORCPT ); Sun, 17 Jun 2007 17:51:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753130AbXFQVvR (ORCPT ); Sun, 17 Jun 2007 17:51:17 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:50766 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754059AbXFQVvQ (ORCPT ); Sun, 17 Jun 2007 17:51:16 -0400 Date: Sun, 17 Jun 2007 23:49:40 +0200 From: Pavel Machek To: "Rafael J. Wysocki" Cc: nigel@nigel.suspend2.net, linux-kernel@vger.kernel.org, suspend-devel List , akpm@linux-foundation.org, Stefan Seyfried Subject: Re: [Suspend-devel] [PATCH, 3rd try] make disable_console_suspend runtime configurable Message-ID: <20070617214940.GA1951@elf.ucw.cz> References: <20070613200303.GB11437@suse.de> <200706141414.22152.rjw@sisk.pl> <200706141559.54242.fseidel@suse.de> <200706150020.29189.rjw@sisk.pl> <20070617213530.GE1803@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070617213530.GE1803@elf.ucw.cz> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > > I hate having to recompile the kernel, just to be able to debug suspend. > > > Remove CONFIG_DISABLE_CONSOLE_SUSPEND, replace it by a tunable in > > > /sys/power/disable_console_suspend. > > > > > > > > > Signed-off-by: Stefan Seyfried > > > Signed-off-by: Frank Seidel > > > --- > > > Third try, renamed sysfs interface to console_suspend > > > reporting and expecting either "enabled" or "disabled" > > > > Thanks a lot for redoing it. > > > > I have no objections. Pavel? > > I still think that patch is bad. I should have screamed when > CONFIG_DISABLE_CONSOLE_SUSPEND went into kernel. That beast should > _not_ be configurable, it should just do the right thing. > > But I realized that too late. And this only makes it works, making > that mistake part of user-kernel interface. > > Sorry for not screaming when CONFIG_DISABLE_CONSOLE_SUSPEND went in, > but please lets solve this correctly.... Ouch and sorry for not screaming at "try 1" time. But it still does not make the patch right, and I believe that even patch authors agree that "no-config-needed" is superior solution. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html