From: Mike Frysinger <vapier@gentoo.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
tony.luck@intel.com
Subject: [patch] dont export ia64 intrin headers and sanitize asm-ia64/byteorder.h
Date: Mon, 18 Jun 2007 15:47:34 -0400 [thread overview]
Message-ID: <200706181547.34793.vapier@gentoo.org> (raw)
In-Reply-To: <20070618183754.GC17112@infradead.org>
On Monday 18 June 2007, Christoph Hellwig wrote:
> On Mon, Jun 18, 2007 at 02:19:10AM -0400, Mike Frysinger wrote:
> > Since asm-ia64/gcc_intrin.h gets exported to userspace, we need to make
> > sure to use __asm__() rather than asm() since the latter is not available
> > when compiling with gcc with GNU extensions turned off (like -std=c99).
>
> This header is only for kernel-internal use and should not be exported
> to userspace at all.
so like the following
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
diff --git a/include/asm-ia64/Kbuild b/include/asm-ia64/Kbuild
index 4a1e48b..fc03b88 100644
--- a/include/asm-ia64/Kbuild
+++ b/include/asm-ia64/Kbuild
@@ -3,10 +3,7 @@ include include/asm-generic/Kbuild.asm
header-y += break.h
header-y += fpu.h
header-y += fpswa.h
-header-y += gcc_intrin.h
header-y += ia64regs.h
-header-y += intel_intrin.h
-header-y += intrinsics.h
header-y += perfmon_default_smpl.h
header-y += ptrace_offsets.h
header-y += rse.h
diff --git a/include/asm-ia64/byteorder.h b/include/asm-ia64/byteorder.h
index 69bd41d..783e272 100644
--- a/include/asm-ia64/byteorder.h
+++ b/include/asm-ia64/byteorder.h
@@ -7,6 +7,9 @@
*/
#include <asm/types.h>
+
+#ifdef __KERNEL__
+
#include <asm/intrinsics.h>
#include <linux/compiler.h>
@@ -35,6 +38,8 @@ __ia64_swab16(__u16 x)
#define __arch__swab32(x) __ia64_swab32(x)
#define __arch__swab16(x) __ia64_swab16(x)
+#endif
+
#define __BYTEORDER_HAS_U64__
#include <linux/byteorder/little_endian.h>
prev parent reply other threads:[~2007-06-18 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 6:19 [patch] use __asm__ and __volatile__ in asm-ia64/gcc_intrin.h Mike Frysinger
2007-06-18 18:37 ` Christoph Hellwig
2007-06-18 19:47 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706181547.34793.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).