linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yinghai Lu <Yinghai.Lu@Sun.COM>
To: Andi Kleen <ak@suse.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Vivek Goyal <vgoyal@in.ibm.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86-64: disable the GART before allocate aperture
Date: Fri, 22 Jun 2007 12:19:15 -0700	[thread overview]
Message-ID: <200706221219.16243.yinghai.lu@sun.com> (raw)

[PATCH] x86-64: disable the GART before allocate aperture

For K8 system: 4G RAM with memory hole remapping enabled, or more than 4G RAM
installed. when mem is allocated for GART, it will do the memset for clear.
and for kexec case, the first kernel already enable that, the memset in second
kernel will cause the system restart. So disable that at first before we try to
allocate mem for it.

Signed-off-by: Yinghai Lu <yinghai.lu@sun.com>

diff --git a/arch/x86_64/kernel/aperture.c b/arch/x86_64/kernel/aperture.c
index a3d450d..7a1b072 100644
--- a/arch/x86_64/kernel/aperture.c
+++ b/arch/x86_64/kernel/aperture.c
@@ -270,6 +270,19 @@ void __init iommu_hole_init(void)
 		printk("This costs you %d MB of RAM\n",
 		       32 << fallback_aper_order);
 
+		/*
+		 * disable it in case it is enabled before, esp for kexec/kdump,
+		 * previous kernel already enable that. otherwise memset called
+		 * by allocate_aperture/__alloc_bootmem_nopanic cause restart.
+		 */
+		for (num = 24; num < 32; num++) {
+			if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00)))
+				continue;
+
+			write_pci_config(0, num, 3, 0x90, 0);
+			write_pci_config(0, num, 3, 0x94, 0);
+		}
+
 		aper_order = fallback_aper_order;
 		aper_alloc = allocate_aperture();
 		if (!aper_alloc) { 

             reply	other threads:[~2007-06-22 19:18 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-22 19:19 Yinghai Lu [this message]
2007-06-22 19:31 ` [PATCH] x86-64: disable the GART before allocate aperture Muli Ben-Yehuda
2007-06-22 19:38   ` Yinghai Lu
2007-06-22 19:49   ` Yinghai Lu
2007-06-22 20:33   ` Alan Cox
2007-06-22 21:28     ` Andi Kleen
2007-06-22 21:38       ` Yinghai Lu
2007-06-22 21:41       ` Eric W. Biederman
2007-06-22 21:32     ` Eric W. Biederman
2007-06-22 21:45       ` Muli Ben-Yehuda
2007-06-22 21:59       ` Yinghai Lu
2007-06-22 22:19       ` Alan Cox
2007-06-22 22:32         ` Eric W. Biederman
2007-06-22 22:43           ` Yinghai Lu
2007-06-22 22:54             ` Alan Cox
2007-06-22 22:57               ` Yinghai Lu
2007-06-22 23:04                 ` Alan Cox
2007-06-22 23:14                   ` Eric W. Biederman
2007-06-23  0:14         ` Andi Kleen
2007-06-23  0:27           ` Yinghai Lu
2007-06-23  0:35             ` Muli Ben-Yehuda
2007-06-23  0:38             ` Andi Kleen
2007-06-23  2:34             ` [PATCH] x86-64: disable the GART in shutdown Yinghai Lu
2007-06-23 10:39               ` Muli Ben-Yehuda
2007-06-23 10:59                 ` Andi Kleen
2007-06-23 11:09                   ` Muli Ben-Yehuda
2007-06-23 11:08               ` Andi Kleen
2007-06-25  0:18                 ` Yinghai Lu
2007-06-23 16:52               ` Andrew Morton
2007-06-25  0:22                 ` Yinghai Lu
2007-06-25  2:10                   ` Muli Ben-Yehuda
2007-06-25 19:34               ` [PATCH] x86-64: disable the GART in shutdown v2 Yinghai Lu
2007-06-25 19:41                 ` Muli Ben-Yehuda
2007-06-25 19:52                   ` Yinghai Lu
2007-06-25 19:56                     ` Muli Ben-Yehuda
2007-06-25 21:48                 ` [PATCH 1/2] x86-64: disable the GART in shutdown Yinghai Lu
2007-06-25 21:49                 ` [PATCH 2/2] x86_84: move iommu declaration from proto to iommu.h Yinghai Lu
2007-06-26 11:43                   ` Muli Ben-Yehuda
2007-06-23  9:08           ` [PATCH] x86-64: disable the GART before allocate aperture Alan Cox
2007-06-23 11:12           ` Vivek Goyal
2007-06-23 13:14             ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200706221219.16243.yinghai.lu@sun.com \
    --to=yinghai.lu@sun.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).