From: Theodore Tso <tytso@mit.edu>
To: Dave Hansen <hansendc@us.ibm.com>
Cc: Joel Schopp <jschopp@austin.ibm.com>,
Andy Whitcroft <apw@shadowen.org>, Andrew Morton <akpm@osdl.org>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] update checkpatch.pl to version 0.06
Date: Fri, 22 Jun 2007 15:16:28 -0400 [thread overview]
Message-ID: <20070622191628.GH15285@thunk.org> (raw)
In-Reply-To: <1182535330.26162.50.camel@localhost>
On Fri, Jun 22, 2007 at 11:02:10AM -0700, Dave Hansen wrote:
> On Fri, 2007-06-22 at 12:54 -0500, Joel Schopp wrote:
> > If it is "kinda like a mini function" why not make it "actually a mini
> > function" and call it?
>
> Several of our on-disk filesystems have an ioctl function that already
> has indented goto labels. I don't think it's quite worth churning all
> of these (working) filesystems to make a style checker happy.
It's not just the on-disk filesystem code. There are examples of both
styles of indentation many other parts of the kernel as well.
- Ted
next prev parent reply other threads:[~2007-06-22 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-22 8:45 [PATCH] update checkpatch.pl to version 0.06 Andy Whitcroft
2007-06-22 17:09 ` Dave Hansen
2007-06-22 17:54 ` Joel Schopp
2007-06-22 18:02 ` Dave Hansen
2007-06-22 18:17 ` Joel Schopp
2007-06-22 19:16 ` Theodore Tso [this message]
2007-06-23 4:04 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070622191628.GH15285@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=hansendc@us.ibm.com \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).