From: Michal Januszewski <spock@gentoo.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] fbdev: uvesafb driver
Date: Sun, 24 Jun 2007 13:15:21 +0200 [thread overview]
Message-ID: <20070624111521.GA8042@spock.one.pl> (raw)
In-Reply-To: <20070623163639.f6b4f20d.akpm@linux-foundation.org>
On Sat, Jun 23, 2007 at 04:36:39PM -0700, Andrew Morton wrote:
> On Sun, 24 Jun 2007 01:20:33 +0200 Michal Januszewski <spock@gentoo.org> wrote:
>
> > > > +config FB_UVESA
> > > > + tristate "Userspace VESA VGA graphics support"
> > > > + depends on FB && CONNECTOR
> > >
> > > These dependencies are insufficient.
> >
> > What exactly is missing here? A dep on X86?
>
> Yes. From your other comments it appears that a dependency on X86_32 is
> needed.
X86_32 is only needed for a bunch of specific operations that make use of
the PMI. The driver can work without those (it has already been tested
on X86_64, where PMI cannot be used).
> > This would indicate the
> > arches on which the driver has actually been tested. But which arches
> > are supported and which aren't is, in the end, up to the userspace helper.
>
> The other architectures won't compile: they don't have mtrr.h
That was my mistake of not putting the mtrr.h include inside a #ifdef
CONFIG_MTRR. After fixing that and a few other things you pointed out
in your previous message, I was able to successfully compile uvesafb for
PPC (using a cross-compiler).
Best regards,
Michal
next prev parent reply other threads:[~2007-06-24 11:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-23 10:52 [PATCH 3/4] fbdev: uvesafb driver Michal Januszewski
2007-06-23 11:51 ` [Linux-fbdev-devel] " Bernhard Fischer
2007-06-23 18:35 ` Andrew Morton
2007-06-23 23:20 ` Michal Januszewski
2007-06-23 23:36 ` Andrew Morton
2007-06-24 11:15 ` Michal Januszewski [this message]
2007-06-24 3:50 ` Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070624111521.GA8042@spock.one.pl \
--to=spock@gentoo.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).