From: Randy Dunlap <randy.dunlap@oracle.com>
To: Torsten Duwe <duwe@lst.de>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: EDD build error
Date: Tue, 26 Jun 2007 15:33:36 -0700 [thread overview]
Message-ID: <20070626153336.e7156b7e.randy.dunlap@oracle.com> (raw)
In-Reply-To: <200706270016.44999.duwe@lst.de>
On Wed, 27 Jun 2007 00:16:44 +0200 Torsten Duwe wrote:
> On Tuesday 26 June 2007, Randy Dunlap wrote:
>
> > ERROR: "pci_get_bus_and_slot" [drivers/firmware/edd.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> >
> > Should EDD depend on PCI or should some parts of edd.c be stubbed?
>
> I'd suggest to simply stub it, as attached (untested, as my crap-Awarded BIOS
> only has 2.1). It may not be nice to pull in the PCI defs and then return NULL
> regardless, but should be safe in your case. Does that work?
>From original email:
(This is in 2.6.22-rc4-mm2 FWIW.)
so quilt+patch says:
Applying patch EDD.diff
patching file drivers/firmware/edd.c
Hunk #1 FAILED at 669.
1 out of 1 hunk FAILED -- rejects in file drivers/firmware/edd.c
Patch EDD.diff does not apply (enforce with -f)
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-06-26 22:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-26 20:26 EDD build error Randy Dunlap
2007-06-26 22:16 ` Torsten Duwe
2007-06-26 22:33 ` Randy Dunlap [this message]
2007-06-26 22:44 ` Torsten Duwe
2007-06-26 23:14 ` Randy Dunlap
[not found] ` <20070627024505.GA30197@humbolt.us.dell.com>
2007-06-27 11:30 ` pci.h stubs (was: EDD build error) Matthew Wilcox
2007-06-27 13:55 ` Alan Cox
2007-06-27 14:03 ` Matthew Wilcox
2007-06-27 14:32 ` Alan Cox
2007-06-27 14:32 ` Matthew Wilcox
2007-06-27 15:07 ` Alan Cox
2007-06-27 16:41 ` pci.h stubs H. Peter Anvin
2007-06-27 16:54 ` Matthew Wilcox
2007-06-27 17:25 ` Alan Cox
2007-06-27 18:34 ` H. Peter Anvin
2007-06-28 23:04 ` [PATCH] PCI: limit pci_get_bus_and_slot to domain 0 Randy Dunlap
2007-06-28 23:48 ` H. Peter Anvin
2007-06-28 23:25 ` [PATCH] pci.h stubs (for EDD build error) Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070626153336.e7156b7e.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=duwe@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).