From: Dave Young <hidave.darkstar@gmail.com>
To: dmitry.torokhov@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] atkbd: cleanup only once
Date: Wed, 27 Jun 2007 10:59:07 +0000 [thread overview]
Message-ID: <20070627105907.GA1802@darkstar.te-china.tietoenator.com> (raw)
Hi,
If you press ctrl+alt+del several times as kernel booting (before user level bootin), the kernel will oops. I found the ps2_command is called more than once, then the ps2dev->serio maybe NULL pointer.
2.6.22-rc5 and 2.6.22-rc6 have same result.
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
---
diff -upr linux/drivers/input/keyboard/atkbd.c linux.new/drivers/input/keyboard/atkbd.c
--- linux/drivers/input/keyboard/atkbd.c 2007-06-27 10:38:37.000000000 +0000
+++ linux.new/drivers/input/keyboard/atkbd.c 2007-06-27 10:37:39.000000000 +0000
@@ -795,6 +795,11 @@ static int atkbd_activate(struct atkbd *
static void atkbd_cleanup(struct serio *serio)
{
+ static int flag;
+
+ if(flag)
+ return;
+ flag = 1;
struct atkbd *atkbd = serio_get_drvdata(serio);
ps2_command(&atkbd->ps2dev, NULL, ATKBD_CMD_RESET_BAT);
}
Regards
dave
next reply other threads:[~2007-06-27 2:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-27 10:59 Dave Young [this message]
2007-06-27 3:01 ` [PATCH] atkbd: cleanup only once dave young
2007-06-27 4:34 ` Dmitry Torokhov
2007-06-27 4:28 ` Greg KH
2007-06-27 4:59 ` Dmitry Torokhov
2007-06-27 5:02 ` dave young
2007-06-28 5:18 ` Dmitry Torokhov
2007-06-28 6:12 ` dave young
2007-06-27 5:27 ` Greg KH
2007-06-27 13:37 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070627105907.GA1802@darkstar.te-china.tietoenator.com \
--to=hidave.darkstar@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).