linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: mel@skynet.ie (Mel Gorman)
Cc: bob.picco@hp.com, apw@shadowen.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix corruption of memmap on IA64 SPARSEMEM when mem_section is not a power of 2
Date: Wed, 25 Jul 2007 13:10:03 -0700	[thread overview]
Message-ID: <20070725131003.1bb80194.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070725125501.GA32445@skynet.ie>

On Wed, 25 Jul 2007 13:55:02 +0100
mel@skynet.ie (Mel Gorman) wrote:

> > mm/sparse.c: In function `sparse_init':
> > mm/sparse.c:482: error: implicit declaration of function `sparse_early_usemap_alloc'
> > mm/sparse.c:482: warning: assignment makes pointer from integer without a cast
> > mm/sparse.c: In function `sparse_add_one_section':
> > mm/sparse.c:553: error: implicit declaration of function `__kmalloc_section_usemap'
> > mm/sparse.c:553: warning: assignment makes pointer from integer without a cast
> 
> I'm looking at this now and getting a superh cross-compiler built to
> build-test any fix. My first impression is that
> sparse_early_usemap_alloc() needs to be defined whether
> CONFIG_SPARSEMEM_VMEMMAP is set or not. Right now,
> sparse_early_usemap_alloc() is only defined when it is set and it's not
> clear why although "by accident" is the most likely explanation.
> 

Thanks.

There's an sh cross-compiler in http://userweb.kernel.org/~akpm/cross-compilers/,
btw.

  reply	other threads:[~2007-07-25 20:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-13 10:42 [PATCH] Fix corruption of memmap on IA64 SPARSEMEM when mem_section is not a power of 2 Mel Gorman
2007-07-25  5:01 ` Andrew Morton
2007-07-25 12:55   ` Mel Gorman
2007-07-25 20:10     ` Andrew Morton [this message]
2007-07-25 14:49   ` Mel Gorman
2007-07-25 14:53     ` Mel Gorman
2007-07-25 16:25     ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070725131003.1bb80194.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=apw@shadowen.org \
    --cc=bob.picco@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mel@skynet.ie \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).