From: Len Brown <lenb@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
david@lang.hm, Andrew Morton <akpm@linux-foundation.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>
Subject: Re: CONFIG_SUSPEND? (was: Re: [GIT PATCH] ACPI patches for 2.6.23-rc1)
Date: Mon, 30 Jul 2007 23:53:18 -0400 [thread overview]
Message-ID: <200707302353.19217.lenb@kernel.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0707280932470.3442@woody.linux-foundation.org>
On Saturday 28 July 2007 12:55, Linus Torvalds wrote:
> So I think the real issue is that we allow that
> "suspend_devices_and_enter()" code to be compiled without HOTPLUG_CPU in
> the first place. It's not supposed to work that way.
I don't see how CONFIG_HOTPLUG_CPU justifies its own existence.
This e-mail thread would have never happened if it were simply included
in CONFIG_SMP, always.
I agree, of course, that ACPI should never have had to work-around
this by selecting HOTPLUG_CPU. But even though it is now done at
the right layer, I don't see why PM should have to
be bothered with selecting HOTPLUG_CPU either --
it should just come with SMP.
-Len
next prev parent reply other threads:[~2007-07-31 3:54 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 16:38 [GIT PATCH] ACPI patches for 2.6.23-rc1 Len Brown
2007-07-25 18:48 ` Linus Torvalds
2007-07-25 22:51 ` Len Brown
2007-07-26 2:20 ` david
2007-07-26 4:26 ` Len Brown
2007-07-26 5:00 ` david
2007-07-26 6:55 ` Linus Torvalds
2007-07-26 17:45 ` Len Brown
2007-07-26 18:01 ` Linus Torvalds
2007-07-26 18:02 ` david
2007-07-26 18:16 ` Linus Torvalds
2007-07-26 18:27 ` Jeff Garzik
2007-07-26 18:18 ` Len Brown
2007-07-26 19:17 ` CONFIG_SUSPEND? (was: Re: [GIT PATCH] ACPI patches for 2.6.23-rc1) Rafael J. Wysocki
2007-07-26 19:57 ` Linus Torvalds
2007-07-26 20:48 ` Rafael J. Wysocki
2007-07-26 20:55 ` Linus Torvalds
2007-07-27 22:25 ` [2.6 patch] let SUSPEND select HOTPLUG_CPU Adrian Bunk
2007-07-27 22:47 ` Stefan Richter
2007-07-27 23:03 ` Adrian Bunk
2007-07-28 8:42 ` Stefan Richter
2007-07-30 21:18 ` Pavel Machek
2007-07-28 14:44 ` Sergio Monteiro Basto
2007-07-27 22:57 ` Linus Torvalds
2007-07-28 4:52 ` [2.6 patch] SOFTWARE_SUSPEND: handle HOTPLUG_CPU automatically Adrian Bunk
2007-07-28 9:07 ` Stefan Richter
2007-07-28 18:30 ` [2.6 patch] let SUSPEND select HOTPLUG_CPU Rafael J. Wysocki
2007-07-28 7:30 ` CONFIG_SUSPEND? (was: Re: [GIT PATCH] ACPI patches for 2.6.23-rc1) Len Brown
2007-07-28 7:33 ` [PATCH] ACPI: restore CONFIG_ACPI_SLEEP Len Brown
2007-07-28 16:25 ` CONFIG_SUSPEND? (was: Re: [GIT PATCH] ACPI patches for 2.6.23-rc1) Linus Torvalds
2007-07-28 16:55 ` Linus Torvalds
2007-07-28 18:29 ` Rafael J. Wysocki
2007-07-28 18:31 ` Linus Torvalds
2007-07-29 10:20 ` [PATCH 0/2] Introduce CONFIG_HIBERNATION and CONFIG_SUSPEND (was: CONFIG_SUSPEND?) Rafael J. Wysocki
2007-07-29 10:21 ` [PATCH 1/2] Replace CONFIG_SOFTWARE_SUSPEND with CONFIG_HIBERNATION Rafael J. Wysocki
2007-07-29 12:38 ` [PATCH 2/2] Introduce CONFIG_SUSPEND Rafael J. Wysocki
2007-07-29 20:40 ` Adrian Bunk
2007-07-29 21:17 ` Rafael J. Wysocki
2007-07-29 21:18 ` Adrian Bunk
2007-07-29 21:36 ` Rafael J. Wysocki
2007-07-29 21:30 ` Richard Hughes
2007-07-29 22:22 ` Rafael J. Wysocki
2007-07-30 21:26 ` Pavel Machek
2007-07-30 2:47 ` Kyle Moffett
2007-07-29 21:23 ` [PATCH 0/2] Introduce CONFIG_HIBERNATION and CONFIG_SUSPEND (updated) Rafael J. Wysocki
2007-07-29 21:24 ` [PATCH 1/2] Replace CONFIG_SOFTWARE_SUSPEND with CONFIG_HIBERNATION (updated) Rafael J. Wysocki
2007-07-29 21:27 ` [PATCH 2/2] Introduce CONFIG_SUSPEND (updated) Rafael J. Wysocki
2007-07-31 4:59 ` Len Brown
2007-07-31 9:15 ` Rafael J. Wysocki
2007-07-31 9:16 ` [linux-pm] " Oliver Neukum
2007-07-31 10:01 ` Rafael J. Wysocki
2007-07-30 0:21 ` [PATCH 0/2] Introduce CONFIG_HIBERNATION and " Linus Torvalds
2007-07-30 7:25 ` Rafael J. Wysocki
2007-07-31 3:54 ` Len Brown
2007-07-31 3:54 ` [PATCH] create CONFIG_SUSPEND_UP_POSSIBLE Len Brown
2007-07-31 6:38 ` Pavel Machek
2007-07-31 9:33 ` Rafael J. Wysocki
2007-08-03 19:23 ` Len Brown
2007-08-05 18:36 ` Pavel Machek
2007-08-01 3:27 ` [PATCH] ACPI: delete CONFIG_ACPI_PROCFS_SLEEP (again) Len Brown
2007-08-01 10:24 ` Rafael J. Wysocki
2007-07-31 3:53 ` Len Brown [this message]
2007-07-31 4:09 ` CONFIG_SUSPEND? (was: Re: [GIT PATCH] ACPI patches for 2.6.23-rc1) david
2007-07-31 6:33 ` Pavel Machek
2007-07-26 10:07 ` [GIT PATCH] ACPI patches for 2.6.23-rc1 Gabriel C
2007-07-26 18:05 ` Len Brown
2007-07-26 18:18 ` Linus Torvalds
2007-07-26 18:38 ` Gabriel C
2007-07-26 18:53 ` defconfig , ACPI=n compile error Gabriel C
2007-07-26 7:02 ` [GIT PATCH] ACPI patches for 2.6.23-rc1 Linus Torvalds
2007-07-27 6:26 ` Jan Dittmer
2007-07-27 16:25 ` Thomas Renninger
2007-07-27 23:50 ` Andreas Schwab
2007-07-28 7:58 ` Jan Dittmer
2007-08-01 1:34 ` Yasha Okshtein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707302353.19217.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@lang.hm \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).