Re: unionfs compile error ( Re: 2.6.23-rc1-mm2 )

From: Erez Zadok <ezk@cs.sunysb.edu>
To: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Gabriel C <nix.or.die@googlemail.com>,
	linux-kernel@vger.kernel.org, ezk@cs.sunysb.edu,
	jsipek@cs.sunysb.edu
Subject: Re: unionfs compile error ( Re: 2.6.23-rc1-mm2 )
Date: Thu, 2 Aug 2007 12:29:59 -0400	[thread overview]
Message-ID: <200708021629.l72GTxFE007558@agora.fsl.cs.sunysb.edu> (raw)
In-Reply-To: Your message of "Wed, 01 Aug 2007 13:27:51 EDT." <20070801172751.GA8565@filer.fsl.cs.sunysb.edu>

In message <20070801172751.GA8565@filer.fsl.cs.sunysb.edu>, Josef Sipek writes:
> On Wed, Aug 01, 2007 at 10:22:07AM -0700, Andrew Morton wrote:
> > On Wed, 01 Aug 2007 12:33:18 +0200 Gabriel C <nix.or.die@googlemail.com> wrote:
> > 
> > > ....
> > > 
> > > fs/unionfs/file.c:147: error: 'file_fsync' undeclared here (not in a function)
> > > make[2]: *** [fs/unionfs/file.o] Error 1
> > > make[1]: *** [fs/unionfs] Error 2
> > > make: *** [fs] Error 2
> > > make: *** Waiting for unfinished jobs....
> > > 
> > > ...
> > > 
> > > Config can be found there -> http://194.231.229.228/MM/config-auto-3
> > > 
> > 
> > This, I assume:
> > 
> > --- a/fs/unionfs/file.c~git-unionfs-fix-2
> > +++ a/fs/unionfs/file.c
> > @@ -17,6 +17,7 @@
> >   */
> >  
> >  #include "union.h"
> > +#include <linux/buffer_head.h>
> >  
> >  /*******************
> >   * File Operations *
> > _
> > 
> > (and no, sorry, I will not be complicit in that
> > single-header-file-which-includes-the-whole-world junk).
> 
> Ouch. I had a fix for this, and it managed to get lost in the pile of
> patches.
> 
> I'll fix it up and push fix to kernel.org.

Jeff, make sure you push my fix which will work even if CONFIG_BLOCK=n is
set.

> Jeff.

Erez.