From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: miklos@szeredi.hu, akpm@linux-foundation.org, neilb@suse.de,
dgc@sgi.com, tomoki.sekiyama.qu@hitachi.com,
a.p.zijlstra@chello.nl, nikita@clusterfs.com,
trond.myklebust@fys.uio.no, yingchao.zhou@gmail.com,
richard@rsk.demon.co.uk, torvalds@linux-foundation.org
Subject: [PATCH 01/23] nfs: remove congestion_end()
Date: Thu, 16 Aug 2007 09:45:26 +0200 [thread overview]
Message-ID: <20070816074624.713614000@chello.nl> (raw)
In-Reply-To: 20070816074525.065850000@chello.nl
[-- Attachment #1: nfs_congestion_fixup.patch --]
[-- Type: text/plain, Size: 1965 bytes --]
Its redundant, clear_bdi_congested() already wakes the waiters.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
fs/nfs/write.c | 5 ++---
include/linux/backing-dev.h | 1 -
mm/backing-dev.c | 13 -------------
3 files changed, 2 insertions(+), 17 deletions(-)
Index: linux-2.6/fs/nfs/write.c
===================================================================
--- linux-2.6.orig/fs/nfs/write.c
+++ linux-2.6/fs/nfs/write.c
@@ -235,10 +235,8 @@ static void nfs_end_page_writeback(struc
struct nfs_server *nfss = NFS_SERVER(inode);
end_page_writeback(page);
- if (atomic_long_dec_return(&nfss->writeback) < NFS_CONGESTION_OFF_THRESH) {
+ if (atomic_long_dec_return(&nfss->writeback) < NFS_CONGESTION_OFF_THRESH)
clear_bdi_congested(&nfss->backing_dev_info, WRITE);
- congestion_end(WRITE);
- }
}
/*
Index: linux-2.6/include/linux/backing-dev.h
===================================================================
--- linux-2.6.orig/include/linux/backing-dev.h
+++ linux-2.6/include/linux/backing-dev.h
@@ -93,7 +93,6 @@ static inline int bdi_rw_congested(struc
void clear_bdi_congested(struct backing_dev_info *bdi, int rw);
void set_bdi_congested(struct backing_dev_info *bdi, int rw);
long congestion_wait(int rw, long timeout);
-void congestion_end(int rw);
#define bdi_cap_writeback_dirty(bdi) \
(!((bdi)->capabilities & BDI_CAP_NO_WRITEBACK))
Index: linux-2.6/mm/backing-dev.c
===================================================================
--- linux-2.6.orig/mm/backing-dev.c
+++ linux-2.6/mm/backing-dev.c
@@ -54,16 +54,3 @@ long congestion_wait(int rw, long timeou
return ret;
}
EXPORT_SYMBOL(congestion_wait);
-
-/**
- * congestion_end - wake up sleepers on a congested backing_dev_info
- * @rw: READ or WRITE
- */
-void congestion_end(int rw)
-{
- wait_queue_head_t *wqh = &congestion_wqh[rw];
-
- if (waitqueue_active(wqh))
- wake_up(wqh);
-}
-EXPORT_SYMBOL(congestion_end);
--
next prev parent reply other threads:[~2007-08-16 8:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-16 7:45 [PATCH 00/23] per device dirty throttling -v9 Peter Zijlstra
2007-08-16 7:45 ` Peter Zijlstra [this message]
2007-08-16 7:45 ` [PATCH 02/23] lib: percpu_counter_add Peter Zijlstra
2007-08-17 15:48 ` Josef Sipek
2007-08-16 7:45 ` [PATCH 03/23] lib: percpu_counter_sub Peter Zijlstra
2007-08-16 7:45 ` [PATCH 04/23] lib: percpu_counter variable batch Peter Zijlstra
2007-08-16 7:45 ` [PATCH 05/23] lib: make percpu_counter_add take s64 Peter Zijlstra
2007-08-16 7:45 ` [PATCH 06/23] lib: percpu_counter_set Peter Zijlstra
2007-08-16 7:45 ` [PATCH 07/23] lib: percpu_counter_sum_positive Peter Zijlstra
2007-08-16 7:45 ` [PATCH 08/23] lib: percpu_count_sum() Peter Zijlstra
2007-08-16 7:45 ` [PATCH 09/23] lib: percpu_counter_init error handling Peter Zijlstra
2007-08-17 15:56 ` Josef Sipek
2007-08-17 16:03 ` Peter Zijlstra
2007-08-18 8:09 ` Peter Zijlstra
2007-08-23 18:24 ` Josef Sipek
2007-08-16 7:45 ` [PATCH 10/23] lib: percpu_counter_init_irq Peter Zijlstra
2007-08-16 7:45 ` [PATCH 11/23] mm: bdi init hooks Peter Zijlstra
2007-08-17 16:10 ` Josef Sipek
2007-08-17 16:15 ` Peter Zijlstra
2007-08-16 7:45 ` [PATCH 12/23] containers: " Peter Zijlstra
2007-08-16 7:45 ` [PATCH 13/23] mtd: " Peter Zijlstra
2007-08-16 7:45 ` [PATCH 14/23] mtd: clean up the backing_dev_info usage Peter Zijlstra
2007-08-16 7:45 ` [PATCH 15/23] mtd: give mtdconcat devices their own backing_dev_info Peter Zijlstra
2007-08-16 7:45 ` [PATCH 16/23] mm: scalable bdi statistics counters Peter Zijlstra
2007-08-17 16:20 ` Josef Sipek
2007-08-17 16:23 ` Peter Zijlstra
2007-08-16 7:45 ` [PATCH 17/23] mm: count reclaimable pages per BDI Peter Zijlstra
2007-08-17 16:23 ` Josef Sipek
2007-08-16 7:45 ` [PATCH 18/23] mm: count writeback " Peter Zijlstra
2007-08-16 7:45 ` [PATCH 19/23] mm: expose BDI statistics in sysfs Peter Zijlstra
2007-08-16 7:45 ` [PATCH 20/23] lib: floating proportions Peter Zijlstra
2007-08-16 7:45 ` [PATCH 21/23] mm: per device dirty threshold Peter Zijlstra
2007-08-16 7:45 ` [PATCH 22/23] mm: dirty balancing for tasks Peter Zijlstra
2007-08-16 7:45 ` [PATCH 23/23] debug: sysfs files for the current ratio/size/total Peter Zijlstra
2007-08-16 21:29 ` [PATCH 00/23] per device dirty throttling -v9 Christoph Lameter
2007-08-17 7:19 ` Peter Zijlstra
2007-08-17 20:37 ` Christoph Lameter
-- strict thread matches above, loose matches on Subject: below --
2007-09-11 19:53 [PATCH 00/23] per device dirty throttling -v10 Peter Zijlstra
2007-09-11 19:53 ` [PATCH 01/23] nfs: remove congestion_end() Peter Zijlstra
2007-08-03 12:37 [PATCH 00/23] per device dirty throttling -v8 Peter Zijlstra
2007-08-03 12:37 ` [PATCH 01/23] nfs: remove congestion_end() Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070816074624.713614000@chello.nl \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.de \
--cc=nikita@clusterfs.com \
--cc=richard@rsk.demon.co.uk \
--cc=tomoki.sekiyama.qu@hitachi.com \
--cc=torvalds@linux-foundation.org \
--cc=trond.myklebust@fys.uio.no \
--cc=yingchao.zhou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).