From: Andrew Morton <akpm@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-am33-list@redhat.com
Subject: Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]
Date: Mon, 12 Nov 2007 11:53:53 -0800 [thread overview]
Message-ID: <20071112115353.227f35cb.akpm@linux-foundation.org> (raw)
In-Reply-To: <6214.1194881680@redhat.com>
On Mon, 12 Nov 2007 15:34:40 +0000 David Howells <dhowells@redhat.com> wrote:
> Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > > +# -*- makefile -*-
> >
> > what's that?
>
> Ah... That tells emacs that it's a makefile. In Kbuild.asm emacs thinks its
> an Assembly file and not a makefile. This causes it to attempt to do
> automatic indentation on it. Do you want me to drop these annotation
> comments?
Doesn't worry me, but I'd suggest that such annotation be added to all such
files in a single separate patch.
otoh it'd be pretty dumb of emacs if there wasn't some way of telling it
the type of a file external from that file itself.
> > Note that because of unexport-asm-pageh.patch I turned the above hunk into
> >
> > ifeq ($(wildcard include/asm-$(SRCARCH)/a.out.h),include/asm-$(SRCARCH)/a.out.h)
> > unifdef-y += a.out.h
> > endif
> >
> > which seems logical to me. We'll see how it tests out.
>
> Are you talking about in linux/Kbuild or in asm-generic/Kbuild.asm or both?
I forget which Kbuild file that was. But with the above change, both
include/asm-generic/Kbuild.asm and include/linux/Kbuild are using
unifdef-y.
> Anyway, it sounds reasonable.
>
> David
next prev parent reply other threads:[~2007-11-12 19:54 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-09 15:34 [PATCH 0/6] MN10300: Add the MN10300 architecture to Linux kernel [try #5] David Howells
2007-11-09 15:34 ` [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT " David Howells
2007-11-11 2:14 ` Andrew Morton
2007-11-11 11:25 ` Adrian Bunk
2007-11-11 13:59 ` David Howells
2007-11-11 14:22 ` Adrian Bunk
2007-11-11 15:03 ` David Howells
2007-11-11 15:19 ` Adrian Bunk
2007-11-11 15:46 ` Andi Kleen
2007-11-11 16:05 ` Adrian Bunk
2007-11-11 16:31 ` David Howells
2007-11-12 15:34 ` David Howells
2007-11-12 19:53 ` Andrew Morton [this message]
2007-11-12 22:50 ` SL Baur
2007-11-12 23:14 ` David Howells
2007-11-13 3:09 ` SL Baur
2007-11-13 10:57 ` David Howells
2007-11-13 11:18 ` Andrew Morton
2007-11-13 12:46 ` Peter Zijlstra
2007-11-13 20:40 ` Matt Mackall
2007-11-13 20:46 ` Peter Zijlstra
2007-12-03 15:15 ` David Howells
2007-12-03 16:00 ` Ralf Baechle
2007-12-03 16:17 ` Adrian Bunk
2007-11-09 15:34 ` [PATCH 2/6] MTD: Add support for the SST 39VF1601 flash chip " David Howells
2007-11-09 22:34 ` David Woodhouse
2007-11-09 15:34 ` [PATCH 3/6] USB: net2280 can't have a function called show_registers() " David Howells
2007-11-09 15:34 ` [PATCH 4/6] MN10300: Allocate serial port UART IDs for on-chip serial ports " David Howells
2007-11-09 15:35 ` [PATCH 6/6] MN10300: Add MTD flash support for the ASB2303 board " David Howells
2007-11-10 4:05 ` David Woodhouse
2007-11-11 14:01 ` David Howells
[not found] ` <20071109153458.20803.10594.stgit@warthog.procyon.org.uk>
2007-11-10 3:53 ` [PATCH 5/6] MN10300: Add the MN10300/AM33 architecture to the kernel " Andrew Morton
2007-11-10 12:18 ` David Howells
2007-11-10 19:43 ` Andrew Morton
2007-11-10 20:02 ` Alan Cox
2007-11-12 7:44 ` Adrian Bunk
2007-11-10 20:09 ` Alan Cox
2007-11-11 14:32 ` David Howells
2007-11-11 14:48 ` David Howells
2007-11-11 15:18 ` Alan Cox
2007-11-11 16:36 ` David Howells
2007-11-11 16:42 ` Alan Cox
2007-11-12 12:19 ` David Howells
2007-11-11 15:07 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071112115353.227f35cb.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-am33-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).