From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754283AbXKMOaM (ORCPT ); Tue, 13 Nov 2007 09:30:12 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754098AbXKMO3r (ORCPT ); Tue, 13 Nov 2007 09:29:47 -0500 Received: from smtp.polymtl.ca ([132.207.4.11]:34110 "EHLO smtp.polymtl.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754028AbXKMO3q (ORCPT ); Tue, 13 Nov 2007 09:29:46 -0500 Message-Id: <20071113142935.522438696@polymtl.ca> References: <20071113142609.103579906@polymtl.ca> User-Agent: quilt/0.46-1 Date: Tue, 13 Nov 2007 09:26:12 -0500 From: Mathieu Desnoyers To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org Cc: Mathieu Desnoyers , Linus Torvalds , Sam Ravnborg Subject: [patch 3/4] Add ARCH_SUPPORTS_KPROBES Content-Disposition: inline; filename=add-arch-supports-kprobes.patch X-Poly-FromMTA: (dijkstra.casi.polymtl.ca [132.207.72.10]) at Tue, 13 Nov 2007 14:29:38 +0000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Linus: On the per-architecture side, I do think it would be better to *not* have internal architecture knowledge in a generic file, and as such a line like depends on X86_32 || IA64 || PPC || S390 || SPARC64 || X86_64 || AVR32 really shouldn't exist in a file like kernel/Kconfig.instrumentation. It would be much better to do depends on ARCH_SUPPORTS_KPROBES in that generic file, and then architectures that do support it would just have a bool ARCH_SUPPORTS_KPROBES default y in *their* architecture files. That would seem to be much more logical, and is readable both for arch maintainers *and* for people who have no clue - and don't care - about which architecture is supposed to support which interface... Changelog: Actually, I know I gave this as the magic incantation, but now that I see it, I realize that I should have told you to just use config ARCH_SUPPORTS_KPROBES def_bool y instead, which is a bit denser. We seem to use both kinds of syntax for these things, but this is really what "def_bool" is there for... Signed-off-by: Mathieu Desnoyers CC: Linus Torvalds CC: Sam Ravnborg --- arch/avr32/Kconfig | 3 +++ arch/ia64/Kconfig | 3 +++ arch/powerpc/Kconfig | 3 +++ arch/ppc/Kconfig | 3 +++ arch/s390/Kconfig | 3 +++ arch/sparc64/Kconfig | 3 +++ arch/x86/Kconfig.i386 | 3 +++ arch/x86/Kconfig.x86_64 | 3 +++ kernel/Kconfig.instrumentation | 2 +- 9 files changed, 25 insertions(+), 1 deletion(-) Index: linux-2.6-lttng/arch/avr32/Kconfig =================================================================== --- linux-2.6-lttng.orig/arch/avr32/Kconfig 2007-11-02 13:20:47.000000000 -0400 +++ linux-2.6-lttng/arch/avr32/Kconfig 2007-11-02 13:20:57.000000000 -0400 @@ -70,6 +70,9 @@ config GENERIC_BUG default y depends on BUG +config ARCH_SUPPORTS_KPROBES + def_bool y + source "init/Kconfig" menu "System Type and features" Index: linux-2.6-lttng/arch/ia64/Kconfig =================================================================== --- linux-2.6-lttng.orig/arch/ia64/Kconfig 2007-11-02 13:20:54.000000000 -0400 +++ linux-2.6-lttng/arch/ia64/Kconfig 2007-11-02 13:20:57.000000000 -0400 @@ -102,6 +102,9 @@ config AUDIT_ARCH config ARCH_SUPPORTS_OPROFILE def_bool y +config ARCH_SUPPORTS_KPROBES + def_bool y + choice prompt "System type" default IA64_GENERIC Index: linux-2.6-lttng/arch/powerpc/Kconfig =================================================================== --- linux-2.6-lttng.orig/arch/powerpc/Kconfig 2007-11-02 13:20:54.000000000 -0400 +++ linux-2.6-lttng/arch/powerpc/Kconfig 2007-11-02 13:20:57.000000000 -0400 @@ -166,6 +166,9 @@ config PPC_OF_PLATFORM_PCI config ARCH_SUPPORTS_OPROFILE def_bool y +config ARCH_SUPPORTS_KPROBES + def_bool y + source "init/Kconfig" source "arch/powerpc/platforms/Kconfig" Index: linux-2.6-lttng/arch/ppc/Kconfig =================================================================== --- linux-2.6-lttng.orig/arch/ppc/Kconfig 2007-11-02 13:20:54.000000000 -0400 +++ linux-2.6-lttng/arch/ppc/Kconfig 2007-11-02 13:20:57.000000000 -0400 @@ -72,6 +72,9 @@ config GENERIC_BUG config ARCH_SUPPORTS_OPROFILE def_bool y +config ARCH_SUPPORTS_KPROBES + def_bool y + source "init/Kconfig" menu "Processor" Index: linux-2.6-lttng/arch/s390/Kconfig =================================================================== --- linux-2.6-lttng.orig/arch/s390/Kconfig 2007-11-02 13:20:54.000000000 -0400 +++ linux-2.6-lttng/arch/s390/Kconfig 2007-11-02 13:20:57.000000000 -0400 @@ -55,6 +55,9 @@ config S390 config ARCH_SUPPORTS_OPROFILE def_bool y +config ARCH_SUPPORTS_KPROBES + def_bool y + source "init/Kconfig" menu "Base setup" Index: linux-2.6-lttng/arch/sparc64/Kconfig =================================================================== --- linux-2.6-lttng.orig/arch/sparc64/Kconfig 2007-11-02 13:20:54.000000000 -0400 +++ linux-2.6-lttng/arch/sparc64/Kconfig 2007-11-02 13:20:57.000000000 -0400 @@ -79,6 +79,9 @@ config GENERIC_HARDIRQS_NO__DO_IRQ config ARCH_SUPPORTS_OPROFILE def_bool y +config ARCH_SUPPORTS_KPROBES + def_bool y + choice prompt "Kernel page size" default SPARC64_PAGE_SIZE_8KB Index: linux-2.6-lttng/arch/x86/Kconfig.i386 =================================================================== --- linux-2.6-lttng.orig/arch/x86/Kconfig.i386 2007-11-02 13:20:54.000000000 -0400 +++ linux-2.6-lttng/arch/x86/Kconfig.i386 2007-11-02 13:20:57.000000000 -0400 @@ -94,6 +94,9 @@ config DMI config ARCH_SUPPORTS_OPROFILE def_bool y +config ARCH_SUPPORTS_KPROBES + def_bool y + source "init/Kconfig" menu "Processor type and features" Index: linux-2.6-lttng/arch/x86/Kconfig.x86_64 =================================================================== --- linux-2.6-lttng.orig/arch/x86/Kconfig.x86_64 2007-11-02 13:20:54.000000000 -0400 +++ linux-2.6-lttng/arch/x86/Kconfig.x86_64 2007-11-02 13:20:57.000000000 -0400 @@ -136,6 +136,9 @@ config ARCH_HAS_ILOG2_U64 config ARCH_SUPPORTS_OPROFILE def_bool y +config ARCH_SUPPORTS_KPROBES + def_bool y + source "init/Kconfig" Index: linux-2.6-lttng/kernel/Kconfig.instrumentation =================================================================== --- linux-2.6-lttng.orig/kernel/Kconfig.instrumentation 2007-11-02 13:20:54.000000000 -0400 +++ linux-2.6-lttng/kernel/Kconfig.instrumentation 2007-11-02 13:20:57.000000000 -0400 @@ -32,7 +32,7 @@ config OPROFILE config KPROBES bool "Kprobes" depends on KALLSYMS && MODULES - depends on X86_32 || IA64 || PPC || S390 || SPARC64 || X86_64 || AVR32 + depends on ARCH_SUPPORTS_KPROBES help Kprobes allows you to trap at almost any kernel address and execute a callback function. register_kprobe() establishes -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68