From: Borislav Petkov <bbpetkov@yahoo.de>
To: Lucy McCoy <lucy@keyspan.com>
Cc: Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] keyspan: init termios properly
Date: Thu, 15 Nov 2007 21:40:47 +0100 [thread overview]
Message-ID: <20071115204047.GA5766@gollum.tnic> (raw)
In-Reply-To: <473C86A2.1060505@keyspan.com>
On Thu, Nov 15, 2007 at 09:49:22AM -0800, Lucy McCoy wrote:
> Greg & Boris,
>
> I've been out of town and just saw this.
>
> This patch will work with the 19HS but WILL BREAK all other Keyspan
> adapters. It will take me a few days to get to looking at a correct fix but
> that keyspan_send_setup(port, 1) (and the '1' is the important part) must
> happen once
> when the port is first opened. The cflag can just be set to whatever the
> normal default
> is for your serial environment. What are the defaults?
Hi Lucy,
sorry but i don't have the other usb-to-serial models to test them too, i guess
you're in the position to do that :) Well, from what i've unterstood from
reading the code, you can still do the keyspan_send_setup() call since the
switch-case-statement is not handling the 19s series so while this call won't have any
influence on them, it'll still init the others properly, no? Anyway, you can send me your
fix for testing.
Thanks.
--
Regards/Gruß,
Boris.
next prev parent reply other threads:[~2007-11-15 20:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 10:03 [PATCH] keyspan: init termios properly Borislav Petkov
2007-11-15 17:49 ` Lucy McCoy
2007-11-15 20:09 ` Andrew Morton
2007-11-15 20:28 ` Lucy McCoy
2007-11-15 20:40 ` Borislav Petkov [this message]
2007-11-15 21:10 Lucy McCoy
2007-11-16 6:24 ` Borislav Petkov
2007-11-18 13:11 ` Borislav Petkov
2007-11-26 22:18 ` Andrew Morton
2007-11-30 5:45 ` Borislav Petkov
2007-11-30 17:23 ` Lucy McCoy
2007-12-02 8:03 ` Borislav Petkov
2007-12-02 13:57 ` Alan Cox
2007-12-02 17:40 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071115204047.GA5766@gollum.tnic \
--to=bbpetkov@yahoo.de \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucy@keyspan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).