linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: niessner@jpl.nasa.gov, Kyle McMartin <kyle@mcmartin.ca>,
	linux-kernel@vger.kernel.org
Subject: Re: Where is the interrupt going?
Date: Fri, 23 Nov 2007 10:36:55 +0000	[thread overview]
Message-ID: <20071123103655.1ee713f1@the-village.bc.nu> (raw)
In-Reply-To: <200711230258.56066.bzolnier@gmail.com>

On Fri, 23 Nov 2007 02:58:55 +0100
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:

> On Friday 23 November 2007, Alan Cox wrote:
> > On Thu, 22 Nov 2007 16:48:53 -0800
> > niessner@jpl.nasa.gov wrote:
> > 
> > > 
> > > I tried the hammer and the problem persists.
> > 
> > See my earlier email - your driver registers the irq with IRQF_DISABLED
> > then never enables it.
> 
> As already explained by Kyle IRQF_DISABLED shouldn't matter here.
> 
> [ Nowadays IRQF_DISABLED only tells kernel/irq/handle.c::handle_IRQ_event()
>   to not enable local interrupts before calling your IRQ handler.
> 
>   I've recently removed IRQF_DISABLED from IDE after noticing this. ]

Bartlomiej is of course correct. Thats what you get for replying late at
night in a hurry.

I'm not sure IDE can work without it because you need to lock out the
timer events (old IDE doesn't handle this at all on SMP though so it
wants fixing properly anyway).

Alan

  reply	other threads:[~2007-11-23 10:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-22  1:08 Where is the interrupt going? Al Niessner
2007-11-22  1:56 ` Alan Cox
2007-11-22  2:14   ` Kyle McMartin
2007-11-22  2:16 ` Jesper Juhl
2007-11-22 23:56   ` niessner
2007-11-22  2:20 ` Kyle McMartin
2007-11-23  0:48   ` niessner
2007-11-23  1:25     ` Alan Cox
2007-11-23  1:58       ` Bartlomiej Zolnierkiewicz
2007-11-23 10:36         ` Alan Cox [this message]
2007-11-23  3:18     ` Marin Mitov
2007-11-23  4:31       ` niessner
2007-11-23  8:16       ` Jiri Slaby
2007-11-22  2:50 ` Arjan van de Ven
2007-11-23 21:53 ` Benjamin Herrenschmidt
2007-11-26 22:49   ` Al Niessner
     [not found] <fa.KsmqgW5tYuaXUkIKwnbJk9eJIAI@ifi.uio.no>
     [not found] ` <fa.JGl5fAfWYHut6bLbEcD35M84qbY@ifi.uio.no>
     [not found]   ` <fa.4GMGd+vtd9BoH5cWYyPKXdddZG4@ifi.uio.no>
2007-11-23  1:20     ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071123103655.1ee713f1@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=kyle@mcmartin.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=niessner@jpl.nasa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).