Re: [patch 1/2] x86, ptrace: support for branch trace store(BTS)

From: Ingo Molnar <mingo@elte.hu>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de,
	ak@suse.de, "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	akpm@linux-foundation.org
Subject: Re: [patch 1/2] x86, ptrace: support for branch trace store(BTS)
Date: Thu, 29 Nov 2007 11:43:25 +0100	[thread overview]
Message-ID: <20071129104325.GF10577@elte.hu> (raw)
In-Reply-To: <029E5BE7F699594398CA44E3DDF5544401024076@swsmsx413.ger.corp.intel.com>

* Metzger, Markus T <markus.t.metzger@intel.com> wrote:

> Changes to previous version(s):
> - moved task arrives/departs notifications to __switch_to_xtra()
> - added _TIF_BTS_TRACE and _TIF_BTS_TRACE_TS to _TIF_WORK_CTXSW_*
> - split _TIF_WORK_CTXSW into ~_PREV and ~_NEXT for x86_64
> - ptrace_bts_init_intel() function called from init_intel()
> - removed PTRACE_BTS_INIT ptrace command
> - cache DEBUGCTRL MSR
> - replace struct declarations and operations struct with
>   configuration struct defining offset/size pairs and
>   generic operations
> - added a patch for the ptrace.2 man page for discussing the API
>   in this forum

i tried to apply your patches to x86.git, but your patches were 
linewrapped and had strange artifacts in them:

| @@ -610,6 +612,32 @@
|                                         (struct user_desc __user *)
| data);
|                 break;
| =20
| +       case PTRACE_BTS_ALLOCATE_BUFFER:
| +

could you please resend with this fixed (preferably against x86.git, 
which has Roland's ptrace cleanups?).

	Ingo