From: Herbert Xu <herbert@gondor.apana.org.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: rae l <crquan@gmail.com>,
Richard Knutsson <ricknu-0@student.ltu.se>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
dengxw@163.com, Randy Dunlap <randy.dunlap@oracle.com>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead
Date: Thu, 29 Nov 2007 22:13:24 +1100 [thread overview]
Message-ID: <20071129111324.GH22537@gondor.apana.org.au> (raw)
In-Reply-To: <20071127012622.3e3a6bd1.akpm@linux-foundation.org>
On Tue, Nov 27, 2007 at 01:26:22AM -0800, Andrew Morton wrote:
> On Tue, 27 Nov 2007 13:03:29 +0800 "rae l" <crquan@gmail.com> wrote:
>
> > -static void hexdump(unsigned char *buf, unsigned int len)
> > +static inline void hexdump(unsigned char *buf, unsigned int len)
> > {
> > - while (len--)
> > - printk("%02x", *buf++);
> > -
> > - printk("\n");
> > + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET,
> > + 16, 1,
> > + buf, len, false);
> > }
>
> uninlining this function shrinks crypto/tcrypt.o's .text from 20,009 bytes
> down to 19,701.
>
> inlining is almost always wrong.
I agree. Please do as Andrew suggests and resubmit.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2007-11-29 11:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 7:13 [PATCH 1/2] crypto test: use print_hex_dump from <linux/kernel.h> Denis Cheng
2007-11-26 14:39 ` Herbert Xu
2007-11-26 17:28 ` [PATCH] [RESEND] crypto test: use print_hex_dump from <linux/kernel.h> instead Denis Cheng
2007-11-26 18:01 ` Joe Perches
2007-11-27 1:35 ` Herbert Xu
2007-11-27 2:47 ` [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead Denis Cheng
2007-11-27 2:58 ` Richard Knutsson
2007-11-27 5:03 ` rae l
2007-11-27 9:26 ` Andrew Morton
2007-11-29 11:13 ` Herbert Xu [this message]
2007-11-30 1:20 ` rae l
2007-11-30 6:00 ` Herbert Xu
2007-11-27 1:05 ` [PATCH] [RESEND] crypto test: use print_hex_dump from <linux/kernel.h> instead Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071129111324.GH22537@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=crquan@gmail.com \
--cc=dengxw@163.com \
--cc=joe@perches.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).