linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johann Wilhelm <johann.wilhelm@student.tugraz.at>
To: Oliver Neukum <oliver@neukum.org>
Cc: Rui Santos <rsantos@grupopie.com>,
	Pete Zaitcev <zaitcev@redhat.com>,
	linux-usb@vger.kernel.org, preining@logic.at,
	kristoffer.ericson@gmail.com, drussell@redhat.com,
	linux-kernel@vger.kernel.org, jsagarribay@gmail.com
Subject: Re: Add the infamous Huawei E220 to option.c
Date: Thu, 29 Nov 2007 15:05:50 +0100	[thread overview]
Message-ID: <20071129150550.86453nubw8i5xi68@webmail.tugraz.at> (raw)
In-Reply-To: <200711291255.08603.oliver@neukum.org>

If everything's working please also add code to also support the other  
E220 device... so both PID 0x1003 and 0x1004 should be treaded the  
same way...

to test the device with the 0x1004-PID maybe Jaime Velasco  
<jsagarribay@gmail.com> could be asked.. he initialy added the lines  
for this device in option.c

73

Zitat von Oliver Neukum <oliver@neukum.org>:

> Am Donnerstag 29 November 2007 schrieb Rui Santos:
>> >> Just to remember that that specific flag was one SET and, was removed,
>> >> in part, because of what I state. Of course we aim at perfection but, if
>> >> the benefits are only for a few situations and, will cause all this
>> >> problems for all other, perhaps the reinsert of that flag would be a
>> >> positive action.
>> >>
>> >
>> > OK, can you provide "lsusb -v" for the device in the CD mode and in
>> > the modem mode?
>> >
>> Of course. Heri it is.
>
> Thanks. Please try this patch.
>
> 	Regards
> 		Oliver
>
> ----
>
> --- a/drivers/usb/serial/option.c	2007-11-29 12:35:09.000000000 +0100
> +++ b/drivers/usb/serial/option.c	2007-11-29 12:47:34.000000000 +0100
> @@ -158,7 +158,7 @@ static struct usb_device_id option_ids[]
>  	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_ETNA_KOI_MODEM) },
>  	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_ETNA_KOI_NETWORK) },
>  	{ USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E600) },
> -	{ USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID,  
> HUAWEI_PRODUCT_E220, 0xff, 0xff, 0xff) },
>  	{ USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E220BIS) },
>  	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1100) }, /* Novatel  
> Merlin XS620/S640 */
>  	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, 0x1110) }, /* Novatel  
> Merlin S620 */
>
>



  reply	other threads:[~2007-11-29 14:07 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-29  0:13 Add the infamous Huawei E220 to option.c Pete Zaitcev
2007-11-29  6:33 ` Johann Wilhelm
2007-11-29  7:44   ` Oliver Neukum
2007-11-29  8:01     ` Pete Zaitcev
2007-11-29  8:14       ` Oliver Neukum
2007-11-29  9:09         ` Matthew Dharm
2007-11-29 10:01           ` Rui Santos
2007-11-29 10:49             ` Oliver Neukum
2007-11-29 11:07               ` Rui Santos
2007-11-29 11:55                 ` Oliver Neukum
2007-11-29 14:05                   ` Johann Wilhelm [this message]
2007-11-29 14:36                     ` Kristoffer Ericson
2007-11-29 14:41                       ` Oliver Neukum
2007-11-29 18:53                     ` Jaime Velasco Juan
2007-11-29 23:23                       ` Oliver Neukum
2007-11-30 16:30                         ` [PATCH] USB: option: Bind to the correct interface of the Huawei E220 Jaime Velasco Juan
2007-12-01  8:07                           ` Norbert Preining
2007-12-01  8:34                             ` Pete Zaitcev
2007-12-01 10:04                               ` Norbert Preining
2007-12-01 18:36                           ` Borislav Petkov
2007-12-05 16:34                           ` Pete Zaitcev
2007-12-05 18:23                             ` Oliver Neukum
2007-12-05 19:14                               ` Pete Zaitcev
2007-11-29 19:12                   ` Add the infamous Huawei E220 to option.c Rui Santos
2007-11-29 17:08       ` Greg KH
2007-11-29  7:38 ` Oliver Neukum
2007-11-29  7:52   ` Pete Zaitcev
2007-11-29  8:04     ` Oliver Neukum
2007-11-29  8:10       ` Pete Zaitcev
2007-11-29 14:14 ` Norbert Preining
2007-11-29 14:16   ` Norbert Preining

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071129150550.86453nubw8i5xi68@webmail.tugraz.at \
    --to=johann.wilhelm@student.tugraz.at \
    --cc=drussell@redhat.com \
    --cc=jsagarribay@gmail.com \
    --cc=kristoffer.ericson@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=preining@logic.at \
    --cc=rsantos@grupopie.com \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).