From: Alexey Dobriyan <adobriyan@sw.ru>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: RFC - organize include/linux/kernel.h, add include/linux/logging.h
Date: Fri, 30 Nov 2007 12:28:43 +0300 [thread overview]
Message-ID: <20071130092842.GA6221@localhost.sw.ru> (raw)
> kernel.h has become a bit disorganized over a long time.
> Here's an attempt to clean it up a bit.
>
> Something for everyone to like or dislike...
You duplicate ALIGN macros all over the place.
> Groups externs and functions by module/function
> Creates a "logging.h" for printk, KERN_<level>
> Changes some macros to statement expressions
> DIV_ROUND_UP, roundup and __ALIGN_MASK
> Removes the unused PTR_ALIGN
> This one used the ALIGN macro, but I'm not inclined to
> figure out what it actually does right now, so copy
> the old macro to this file and renames it.
Which is not acceptable. Ditto for DIV_ROUND_UP.
And you somehow decided that putting statements on one line is more
readable than on multiple lines -- typecheck and friends.
Overall impression -- moving code just because you can.
next reply other threads:[~2007-11-30 9:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 9:28 Alexey Dobriyan [this message]
2007-11-30 18:04 ` RFC - organize include/linux/kernel.h, add include/linux/logging.h Joe Perches
2007-11-30 18:09 ` Jan Engelhardt
2007-11-30 19:20 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2007-11-30 3:31 Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071130092842.GA6221@localhost.sw.ru \
--to=adobriyan@sw.ru \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).