* [BUG] 2.6.24-rc3 x86 make depends on s390 arch
@ 2007-11-30 8:14 Jaswinder Singh
2007-11-30 10:37 ` Heiko Carstens
2007-11-30 11:03 ` [PATCH] " Jaswinder Singh
0 siblings, 2 replies; 9+ messages in thread
From: Jaswinder Singh @ 2007-11-30 8:14 UTC (permalink / raw)
To: LKML
2.6.24-rc3 git kernel's x86 make depends on s390 arch:
1. HOSTLD scripts/kconfig/conf
scripts/kconfig/conf -s arch/x86/Kconfig
drivers/crypto/Kconfig:51: can't open file "arch/s390/crypto/Kconfig"
make[2]: *** [silentoldconfig] Error 1
make[1]: *** [silentoldconfig] Error 2
2. CC kernel/sysctl_check.o
kernel/sysctl_check.c:3:44: error: ../arch/s390/appldata/appldata.h:
No such file or directory
make[1]: *** [kernel/sysctl_check.o] Error 1
make: *** [kernel] Error 2
Thank you,
Jaswinder Singh.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch
2007-11-30 8:14 [BUG] 2.6.24-rc3 x86 make depends on s390 arch Jaswinder Singh
@ 2007-11-30 10:37 ` Heiko Carstens
2007-11-30 11:16 ` Jaswinder Singh
2007-11-30 11:03 ` [PATCH] " Jaswinder Singh
1 sibling, 1 reply; 9+ messages in thread
From: Heiko Carstens @ 2007-11-30 10:37 UTC (permalink / raw)
To: Jaswinder Singh; +Cc: LKML
On Fri, Nov 30, 2007 at 01:44:56PM +0530, Jaswinder Singh wrote:
> 2.6.24-rc3 git kernel's x86 make depends on s390 arch:
>
> 1. HOSTLD scripts/kconfig/conf
> scripts/kconfig/conf -s arch/x86/Kconfig
> drivers/crypto/Kconfig:51: can't open file "arch/s390/crypto/Kconfig"
> make[2]: *** [silentoldconfig] Error 1
> make[1]: *** [silentoldconfig] Error 2
>
> 2. CC kernel/sysctl_check.o
> kernel/sysctl_check.c:3:44: error: ../arch/s390/appldata/appldata.h:
> No such file or directory
> make[1]: *** [kernel/sysctl_check.o] Error 1
> make: *** [kernel] Error 2
Could it be that you deleted half of the kernel tree? In specific
arch/[everything besides x86]*/ ?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch
2007-11-30 8:14 [BUG] 2.6.24-rc3 x86 make depends on s390 arch Jaswinder Singh
2007-11-30 10:37 ` Heiko Carstens
@ 2007-11-30 11:03 ` Jaswinder Singh
2007-11-30 11:50 ` Heiko Carstens
1 sibling, 1 reply; 9+ messages in thread
From: Jaswinder Singh @ 2007-11-30 11:03 UTC (permalink / raw)
To: LKML
This patch fixes s390 dependency for x86
Signed-off-by: Jaswinder Singh <jaswinderlinux@gmail.com>
diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
index 1330061..b699ed5 100644
--- a/arch/s390/Kconfig
+++ b/arch/s390/Kconfig
@@ -537,4 +537,6 @@ source "security/Kconfig"
source "crypto/Kconfig"
+source "arch/s390/crypto/Kconfig"
+
source "lib/Kconfig"
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 5fd6688..5c2c7eb 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -48,8 +48,6 @@ config CRYPTO_DEV_PADLOCK_SHA
If unsure say M. The compiled module will be
called padlock-sha.ko
-source "arch/s390/crypto/Kconfig"
-
config CRYPTO_DEV_GEODE
tristate "Support for the Geode LX AES engine"
depends on X86_32 && PCI
diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c
index 6972f26..529be08 100644
--- a/kernel/sysctl_check.c
+++ b/kernel/sysctl_check.c
@@ -1,6 +1,8 @@
#include <linux/stat.h>
#include <linux/sysctl.h>
+#ifdef CONFIG_S390
#include "../arch/s390/appldata/appldata.h"
+#endif
#include "../fs/xfs/linux-2.6/xfs_sysctl.h"
#include <linux/sunrpc/debug.h>
#include <linux/string.h>
On 11/30/07, Jaswinder Singh <jaswinderlinux@gmail.com> wrote:
> 2.6.24-rc3 git kernel's x86 make depends on s390 arch:
>
> 1. HOSTLD scripts/kconfig/conf
> scripts/kconfig/conf -s arch/x86/Kconfig
> drivers/crypto/Kconfig:51: can't open file "arch/s390/crypto/Kconfig"
> make[2]: *** [silentoldconfig] Error 1
> make[1]: *** [silentoldconfig] Error 2
>
> 2. CC kernel/sysctl_check.o
> kernel/sysctl_check.c:3:44: error: ../arch/s390/appldata/appldata.h:
> No such file or directory
> make[1]: *** [kernel/sysctl_check.o] Error 1
> make: *** [kernel] Error 2
>
> Thank you,
>
> Jaswinder Singh.
>
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch
2007-11-30 10:37 ` Heiko Carstens
@ 2007-11-30 11:16 ` Jaswinder Singh
0 siblings, 0 replies; 9+ messages in thread
From: Jaswinder Singh @ 2007-11-30 11:16 UTC (permalink / raw)
To: Heiko Carstens; +Cc: LKML
Yes, what is the use of keeping other arch, if I am not going to build those.
Thank you,
Jaswinder Singh.
On 11/30/07, Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> On Fri, Nov 30, 2007 at 01:44:56PM +0530, Jaswinder Singh wrote:
> > 2.6.24-rc3 git kernel's x86 make depends on s390 arch:
> >
> > 1. HOSTLD scripts/kconfig/conf
> > scripts/kconfig/conf -s arch/x86/Kconfig
> > drivers/crypto/Kconfig:51: can't open file "arch/s390/crypto/Kconfig"
> > make[2]: *** [silentoldconfig] Error 1
> > make[1]: *** [silentoldconfig] Error 2
> >
> > 2. CC kernel/sysctl_check.o
> > kernel/sysctl_check.c:3:44: error: ../arch/s390/appldata/appldata.h:
> > No such file or directory
> > make[1]: *** [kernel/sysctl_check.o] Error 1
> > make: *** [kernel] Error 2
>
> Could it be that you deleted half of the kernel tree? In specific
> arch/[everything besides x86]*/ ?
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch
2007-11-30 11:03 ` [PATCH] " Jaswinder Singh
@ 2007-11-30 11:50 ` Heiko Carstens
2007-11-30 12:08 ` Jaswinder Singh
0 siblings, 1 reply; 9+ messages in thread
From: Heiko Carstens @ 2007-11-30 11:50 UTC (permalink / raw)
To: Jaswinder Singh; +Cc: LKML, Jan Glauber
On Fri, Nov 30, 2007 at 04:33:19PM +0530, Jaswinder Singh wrote:
> This patch fixes s390 dependency for x86
>
> Signed-off-by: Jaswinder Singh <jaswinderlinux@gmail.com>
Deleting random parts of the kernel tree is actually not
supported.
> diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> index 1330061..b699ed5 100644
> --- a/arch/s390/Kconfig
> +++ b/arch/s390/Kconfig
> @@ -537,4 +537,6 @@ source "security/Kconfig"
>
> source "crypto/Kconfig"
>
> +source "arch/s390/crypto/Kconfig"
> +
With this there's no dependency on CRYPTO_HW anymore.
> +#ifdef CONFIG_S390
> #include "../arch/s390/appldata/appldata.h"
> +#endif
This include can go away.
Since this pops up again and again we'll come up with a patch to fix this.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch
2007-11-30 11:50 ` Heiko Carstens
@ 2007-11-30 12:08 ` Jaswinder Singh
2007-11-30 12:49 ` Heiko Carstens
0 siblings, 1 reply; 9+ messages in thread
From: Jaswinder Singh @ 2007-11-30 12:08 UTC (permalink / raw)
To: Heiko Carstens; +Cc: LKML, Jan Glauber
On 11/30/07, Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> On Fri, Nov 30, 2007 at 04:33:19PM +0530, Jaswinder Singh wrote:
> > This patch fixes s390 dependency for x86
> >
> > Signed-off-by: Jaswinder Singh <jaswinderlinux@gmail.com>
>
> Deleting random parts of the kernel tree is actually not
> supported.
>
I agree with you. I just did this to same some space because I keep
many kernel trees.
But i am curious if other arch do not depends on x86 then s390 ?
> > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> > index 1330061..b699ed5 100644
> > --- a/arch/s390/Kconfig
> > +++ b/arch/s390/Kconfig
> > @@ -537,4 +537,6 @@ source "security/Kconfig"
> >
> > source "crypto/Kconfig"
> >
> > +source "arch/s390/crypto/Kconfig"
> > +
>
> With this there's no dependency on CRYPTO_HW anymore.
>
Anyhow "if CRYPTO_HW" is not working in drivers/crypto/Kconfig
have you tested this patch on S390. Is this giving errors ?
And you can also add depends with CRYPTO_HW in arch/s390/crypto/Kconfig
Thank you,
Jaswinder Singh.
> > +#ifdef CONFIG_S390
> > #include "../arch/s390/appldata/appldata.h"
> > +#endif
>
> This include can go away.
>
> Since this pops up again and again we'll come up with a patch to fix this.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch
2007-11-30 12:08 ` Jaswinder Singh
@ 2007-11-30 12:49 ` Heiko Carstens
2007-11-30 13:00 ` Jaswinder Singh
0 siblings, 1 reply; 9+ messages in thread
From: Heiko Carstens @ 2007-11-30 12:49 UTC (permalink / raw)
To: Jaswinder Singh; +Cc: LKML, Jan Glauber
> > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> > > index 1330061..b699ed5 100644
> > > --- a/arch/s390/Kconfig
> > > +++ b/arch/s390/Kconfig
> > > @@ -537,4 +537,6 @@ source "security/Kconfig"
> > >
> > > source "crypto/Kconfig"
> > >
> > > +source "arch/s390/crypto/Kconfig"
> > > +
> >
> > With this there's no dependency on CRYPTO_HW anymore.
> >
>
> Anyhow "if CRYPTO_HW" is not working in drivers/crypto/Kconfig
>
> have you tested this patch on S390. Is this giving errors ?
>
> And you can also add depends with CRYPTO_HW in arch/s390/crypto/Kconfig
Jan just created a patch which moves everything from arch/s390/crypto/Kconfig
to drivers/crypto/Kconfig. Probably will be merged during the 2.6.25 merge
window.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch
2007-11-30 12:49 ` Heiko Carstens
@ 2007-11-30 13:00 ` Jaswinder Singh
2007-11-30 13:37 ` Heiko Carstens
0 siblings, 1 reply; 9+ messages in thread
From: Jaswinder Singh @ 2007-11-30 13:00 UTC (permalink / raw)
To: Heiko Carstens; +Cc: LKML, Jan Glauber
We have two options:
1. Either move arch/s390/crypto/Kconfig to drivers/crypto/Kconfig
OR
2. In arch/s390/crypto/Kconfig , replace "depends on S390" to "depends
on CRYPRO_HW"
I think 2nd option is better for everyone.
Thank you,
Jaswinder Singh.
On 11/30/07, Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> > > > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig
> > > > index 1330061..b699ed5 100644
> > > > --- a/arch/s390/Kconfig
> > > > +++ b/arch/s390/Kconfig
> > > > @@ -537,4 +537,6 @@ source "security/Kconfig"
> > > >
> > > > source "crypto/Kconfig"
> > > >
> > > > +source "arch/s390/crypto/Kconfig"
> > > > +
> > >
> > > With this there's no dependency on CRYPTO_HW anymore.
> > >
> >
> > Anyhow "if CRYPTO_HW" is not working in drivers/crypto/Kconfig
> >
> > have you tested this patch on S390. Is this giving errors ?
> >
> > And you can also add depends with CRYPTO_HW in arch/s390/crypto/Kconfig
>
> Jan just created a patch which moves everything from
> arch/s390/crypto/Kconfig
> to drivers/crypto/Kconfig. Probably will be merged during the 2.6.25 merge
> window.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Re: [BUG] 2.6.24-rc3 x86 make depends on s390 arch
2007-11-30 13:00 ` Jaswinder Singh
@ 2007-11-30 13:37 ` Heiko Carstens
0 siblings, 0 replies; 9+ messages in thread
From: Heiko Carstens @ 2007-11-30 13:37 UTC (permalink / raw)
To: Jaswinder Singh; +Cc: LKML, Jan Glauber
On Fri, Nov 30, 2007 at 06:30:45PM +0530, Jaswinder Singh wrote:
> We have two options:
>
> 1. Either move arch/s390/crypto/Kconfig to drivers/crypto/Kconfig
>
> OR
>
> 2. In arch/s390/crypto/Kconfig , replace "depends on S390" to "depends
> on CRYPRO_HW"
>
> I think 2nd option is better for everyone.
2) won't work and doesn't make too much sense. So it's 1).
This isn't worth discussing any furter.
Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2007-11-30 13:37 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-30 8:14 [BUG] 2.6.24-rc3 x86 make depends on s390 arch Jaswinder Singh
2007-11-30 10:37 ` Heiko Carstens
2007-11-30 11:16 ` Jaswinder Singh
2007-11-30 11:03 ` [PATCH] " Jaswinder Singh
2007-11-30 11:50 ` Heiko Carstens
2007-11-30 12:08 ` Jaswinder Singh
2007-11-30 12:49 ` Heiko Carstens
2007-11-30 13:00 ` Jaswinder Singh
2007-11-30 13:37 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).