From: Ingo Molnar <mingo@elte.hu>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>, Andi Kleen <ak@suse.de>,
tglx@linutronix.de, mingo@redhat.com
Subject: Re: [patch 05/10] x86_64: Use generic percpu
Date: Fri, 30 Nov 2007 12:11:42 +0100 [thread overview]
Message-ID: <20071130111142.GC32431@elte.hu> (raw)
In-Reply-To: <20071128211527.128796367@sgi.com>
had rejects - hand-merged to x86.git - please check.
Ingo
---------------->
Subject: x86_64: Use generic percpu
From: Christoph Lameter <clameter@sgi.com>
x86_64 provides an optimized way to determine the local per cpu area
offset through the pda and determines the base by accessing a remote
pda.
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
include/asm-x86/percpu_64.h | 28 +++-------------------------
1 file changed, 3 insertions(+), 25 deletions(-)
Index: linux-x86.q/include/asm-x86/percpu_64.h
===================================================================
--- linux-x86.q.orig/include/asm-x86/percpu_64.h
+++ linux-x86.q/include/asm-x86/percpu_64.h
@@ -8,25 +8,13 @@
from %gs */
#ifdef CONFIG_SMP
-
#include <asm/pda.h>
#define __per_cpu_offset(cpu) (cpu_pda(cpu)->data_offset)
-#define __my_cpu_offset() read_pda(data_offset)
+#define __my_cpu_offset read_pda(data_offset)
#define per_cpu_offset(x) (__per_cpu_offset(x))
-/* var is in discarded region: offset to particular copy we want */
-#define per_cpu(var, cpu) (*({ \
- extern int simple_identifier_##var(void); \
- RELOC_HIDE(&per_cpu__##var, __per_cpu_offset(cpu)); }))
-#define __get_cpu_var(var) (*({ \
- extern int simple_identifier_##var(void); \
- RELOC_HIDE(&per_cpu__##var, __my_cpu_offset()); }))
-#define __raw_get_cpu_var(var) (*({ \
- extern int simple_identifier_##var(void); \
- RELOC_HIDE(&per_cpu__##var, __my_cpu_offset()); }))
-
/* A macro to avoid #include hell... */
#define percpu_modcopy(pcpudst, src, size) \
do { \
@@ -36,16 +24,6 @@ do { \
(src), (size)); \
} while (0)
-extern void setup_per_cpu_areas(void);
-
-#else /* ! SMP */
-
-#define per_cpu(var, cpu) (*((void)(cpu), &per_cpu__##var))
-#define __get_cpu_var(var) per_cpu__##var
-#define __raw_get_cpu_var(var) per_cpu__##var
-
-#endif /* SMP */
-
-#define DECLARE_PER_CPU(type, name) extern __typeof__(type) per_cpu__##name
-
+#endif
+#include <asm-generic/percpu.h>
#endif /* _ASM_X8664_PERCPU_H_ */
next prev parent reply other threads:[~2007-11-30 11:12 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 21:09 [patch 00/10] Per cpu code simplification V2 Christoph Lameter
2007-11-28 21:09 ` [patch 01/10] percpu: Use a kconfig variable to signal arch specific percpu setup Christoph Lameter
2007-11-28 21:09 ` [patch 02/10] percpu: Move arch XX_PER_CPU_XX definitions into linux/percpu.h Christoph Lameter
2007-11-28 21:09 ` [patch 03/10] percpu: Make the asm-generic/percpu.h more "generic" Christoph Lameter
2007-11-30 11:10 ` Ingo Molnar
2007-11-30 17:09 ` Christoph Lameter
2007-11-30 17:14 ` Ingo Molnar
2007-11-30 17:17 ` Christoph Lameter
2007-11-30 17:58 ` Ingo Molnar
2007-11-30 18:12 ` Ingo Molnar
2007-11-30 18:42 ` Christoph Lameter
2007-11-30 18:49 ` Ingo Molnar
2007-11-30 19:01 ` Christoph Lameter
2007-11-30 19:33 ` Christoph Lameter
2007-11-30 20:13 ` Ingo Molnar
2007-11-28 21:09 ` [patch 04/10] x86_32: Use generic percpu.h Christoph Lameter
2007-11-30 11:11 ` Ingo Molnar
2007-11-28 21:09 ` [patch 05/10] x86_64: Use generic percpu Christoph Lameter
2007-11-30 11:11 ` Ingo Molnar [this message]
2007-11-28 21:09 ` [patch 06/10] s390: " Christoph Lameter
2007-11-29 15:56 ` Martin Schwidefsky
2007-11-29 18:16 ` Christoph Lameter
2007-11-28 21:09 ` [patch 07/10] Powerpc: Use generic per cpu Christoph Lameter
2007-11-28 21:09 ` [patch 08/10] Sparc64: Use generic percpu Christoph Lameter
2007-11-28 21:09 ` [patch 09/10] ia64: " Christoph Lameter
2007-11-28 21:09 ` [patch 10/10] x86: Unify percpu.h Christoph Lameter
2007-11-30 11:14 ` Ingo Molnar
2007-12-28 0:10 [PATCH 00/10] percpu: Per cpu code simplification V2 travis
2007-12-28 0:10 ` [PATCH 05/10] x86_64: Use generic percpu travis
2007-12-28 12:54 ` Andi Kleen
2007-12-28 22:05 ` Mike Travis
2007-12-29 1:55 ` Andi Kleen
2007-12-31 16:19 ` Mike Travis
2008-01-02 20:58 ` Christoph Lameter
2007-12-30 14:18 ` Ingo Molnar
2007-12-31 16:21 ` Mike Travis
2007-12-31 17:10 ` Mike Travis
2008-01-01 19:17 ` Ingo Molnar
2008-01-02 21:04 ` Christoph Lameter
2008-01-02 21:33 ` Ingo Molnar
2008-01-02 20:59 ` Christoph Lameter
2008-01-02 20:55 ` Christoph Lameter
2007-12-28 0:16 [PATCH 00/10] percpu: Per cpu code simplification V2 travis
2007-12-28 0:16 ` [PATCH 05/10] x86_64: Use generic percpu travis
2008-01-08 2:11 [PATCH 00/10] percpu: Per cpu code simplification V3 travis
2008-01-08 2:11 ` [PATCH 05/10] x86_64: Use generic percpu travis
2008-01-08 21:10 [PATCH 00/10] percpu: Per cpu code simplification V4 travis
2008-01-08 21:10 ` [PATCH 05/10] x86_64: Use generic percpu travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071130111142.GC32431@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).