linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Rene Herman <rene.herman@keyaccess.nl>
Cc: trenn@suse.de, linux-kernel <linux-kernel@vger.kernel.org>,
	akpm <akpm@linux-foundation.org>,
	"Li, Shaohua" <shaohua.li@intel.com>
Subject: Re: [PATCH] Declare PNP option parsing functions as __init
Date: Fri, 30 Nov 2007 16:52:41 -0700	[thread overview]
Message-ID: <200711301652.42110.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <47509EB6.20300@keyaccess.nl>

On Friday 30 November 2007 04:37:26 pm Rene Herman wrote:
> On 30-11-07 18:04, Thomas Renninger wrote:
> > If I have not overseen something, it should be rather obvious that those
> > can all be declared __init...
> > ---------------
> > 
> > Declare PNP option parsing functions as __init
> > 
> > There are three kind of parse functions provided by PNP acpi/bios:
> >  - get current resources
> >  - set resources
> >  - get possible resources
> > The first two may be needed later at runtime.
> > The possible resource settings should never change dynamically.
> > And even if this would make any sense (I doubt it), the current implementation
> > only parses possible resource settings at early init time:
> >   -> declare all the option parsing __init
> > 
> > Signed-off-by: Thomas Renninger <trenn@suse.de>
> 
> Yes. Obviousness aside,
> 
> (0) pnpacpi_add_device                          is only caller of
> ...

I agree this is probably safe in the current implementation.

However, I think the current implementation is just broken because
we can't really handle hotplug of ACPI devices.  Specifically, I think
the first TBD in acpi_bus_check_device() should be fleshed out so it
does something like pnpacpi_add_device().

So my dissenting opinion is that this patch would just get reverted
soon anyway when somebody finishes implementing ACPI hotplug, and
therefore it's not worth doing.

Bjorn

  reply	other threads:[~2007-12-01  0:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-30 17:04 [PATCH] Declare PNP option parsing functions as __init Thomas Renninger
2007-11-30 23:37 ` Rene Herman
2007-11-30 23:52   ` Bjorn Helgaas [this message]
2007-12-01  0:33     ` Rene Herman
2007-12-02 13:34       ` Thomas Renninger
2007-12-02 13:50         ` Rene Herman
2007-12-02 13:32     ` Thomas Renninger
2007-12-03 11:53     ` Thomas Renninger
2007-12-03 15:52       ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711301652.42110.bjorn.helgaas@hp.com \
    --to=bjorn.helgaas@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rene.herman@keyaccess.nl \
    --cc=shaohua.li@intel.com \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).