From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Adrian Bunk <bunk@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Avoid overflows in kernel/time.c
Date: Sat, 1 Dec 2007 13:33:59 +0000 [thread overview]
Message-ID: <20071201133359.2e609976@the-village.bc.nu> (raw)
In-Reply-To: <20071201132047.2bf3c40c@the-village.bc.nu>
On Sat, 1 Dec 2007 13:20:47 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Sat, 1 Dec 2007 01:33:33 +0100
> Adrian Bunk <bunk@kernel.org> wrote:
>
> > On Thu, Nov 29, 2007 at 04:19:51PM -0800, H. Peter Anvin wrote:
> > > When the conversion factor between jiffies and milli- or microseconds
> > > is not a single multiply or divide, as for the case of HZ == 300, we
> > > currently do a multiply followed by a divide. The intervening
> > > result, however, is subject to overflows, especially since the
> > > fraction is not simplified (for HZ == 300, we multiply by 300 and
> > > divide by 1000).
> > >...
> > > kernel/Makefile | 8 +++
> > > kernel/time.c | 29 +++++++++---
> > > kernel/timeconst.bc | 123 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > > 3 files changed, 152 insertions(+), 8 deletions(-)
> > > create mode 100644 kernel/timeconst.bc
> > >...
> >
> > I have read the hep text, but are the advantages of HZ == 300 really
> > visible or was this more theoretical?
>
> Its visibile for people doing PAL media processing and TV sync work.
Wake up Alan - NTSC for 300HZ, PAL is OK at 250HZ setting.
Alan
next prev parent reply other threads:[~2007-12-01 13:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 0:19 [PATCH] Avoid overflows in kernel/time.c H. Peter Anvin
2007-11-30 1:54 ` Andrew Morton
2007-11-30 3:01 ` H. Peter Anvin
2007-11-30 3:27 ` [PATCH] Documentation/Changes -> Documentation/Requirements H. Peter Anvin
2007-11-30 3:32 ` [PATCH] Documentation/Changes -> Documentation/Requirements (resend without truncated comment text) H. Peter Anvin
2007-11-30 7:16 ` Jarek Poplawski
2007-11-30 17:40 ` H. Peter Anvin
2007-11-30 17:47 ` [PATCH] Documentation/Changes -> Documentation/Requirements H. Peter Anvin
2007-11-30 18:09 ` Robert P. J. Day
2007-11-30 18:20 ` H. Peter Anvin
2007-11-30 1:59 ` [PATCH] Avoid overflows in kernel/time.c Chris Snook
2007-11-30 3:04 ` H. Peter Anvin
2007-11-30 3:40 ` Arjan van de Ven
2007-11-30 3:54 ` H. Peter Anvin
2007-12-02 18:37 ` Pavel Machek
2007-12-03 14:53 ` Jan Engelhardt
2007-12-10 16:37 ` H. Peter Anvin
2007-12-01 0:33 ` Adrian Bunk
2007-12-01 4:19 ` H. Peter Anvin
2007-12-01 13:20 ` Alan Cox
2007-12-01 13:33 ` Alan Cox [this message]
2007-12-02 1:53 ` H. Peter Anvin
2007-12-07 0:22 ` Jeremy Fitzhardinge
2007-12-04 11:29 ` Andrew Morton
2007-12-10 16:46 ` H. Peter Anvin
2007-12-10 18:59 ` H. Peter Anvin
2007-12-10 22:04 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071201133359.2e609976@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).