From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756184AbXLBUSh@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756184AbXLBUSh (ORCPT <rfc822;w@1wt.eu>);
	Sun, 2 Dec 2007 15:18:37 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753943AbXLBUS3
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sun, 2 Dec 2007 15:18:29 -0500
Received: from ogre.sisk.pl ([217.79.144.158]:38584 "EHLO ogre.sisk.pl"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750888AbXLBUS2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 2 Dec 2007 15:18:28 -0500
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Mark M. Hoffman" <mhoffman@lightlink.com>
Subject: Re: [lm-sensors] [PATCH 1/1] HWMON: coretemp, suspend fix
Date: Sun, 2 Dec 2007 21:36:47 +0100
User-Agent: KMail/1.9.6 (enterprise 20070904.708012)
Cc: Jiri Slaby <jirislaby@gmail.com>, Jean Delvare <khali@linux-fr.org>,
       Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org,
       lm-sensors@lm-sensors.org
References: <661416096128474967.slaby@pripojeni.net> <200712010051.41227.rjw@sisk.pl> <20071202162814.GZ13717@jupiter.solarsys.private>
In-Reply-To: <20071202162814.GZ13717@jupiter.solarsys.private>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200712022136.48511.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday, 2 of December 2007, Mark M. Hoffman wrote:
> Hi:
> 
> * Rafael J. Wysocki <rjw@sisk.pl> [2007-12-01 00:51:40 +0100]:
> > On Saturday, 1 of December 2007, Rafael J. Wysocki wrote:
> > > On Friday, 30 of November 2007, Jiri Slaby wrote:
> > > > On 11/30/2007 11:15 PM, Jean Delvare wrote:

[--snip--]
> 
> PS: while reading kernel/power/disk.c, I saw this...
> 
> 335 static void power_down(void)
> 336 {
> 337         switch (hibernation_mode) {
> 338         case HIBERNATION_TEST:
> 339         case HIBERNATION_TESTPROC:
> 340                 break;
> 341         case HIBERNATION_REBOOT:
> 342                 kernel_restart(NULL);
> 343                 break;
> 344         case HIBERNATION_PLATFORM:
> 345                 hibernation_platform_enter();
> 346         case HIBERNATION_SHUTDOWN:
> 347                 kernel_power_off();
> 348                 break;
> 349         }
> 350         kernel_halt();
> 351         /*
> 352          * Valid image is on the disk, if we continue we risk serious data
> 353          * corruption after resume.
> 354          */
> 355         printk(KERN_CRIT "Please power me down manually\n");
> 356         while(1);
> 357 }
> 
> Shouldn't that be while(1) cpu_relax(); ?

Yes, it should.

Thanks for pointing that out, I'll fix it.

Greetings,
Rafael