From: "Ed L. Cashin" <ecashin@coraid.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: jnelson-kernel-bugzilla@jamponi.net,
bugme-daemon@bugzilla.kernel.org, nickpiggin@yahoo.com.au,
clameter@sgi.com, linux-kernel@vger.kernel.org, rjw@sisk.pl,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [Bugme-new] [Bug 9482] New: kernel GPF in 2.6.24 (g09f345da)
Date: Mon, 3 Dec 2007 18:24:28 -0500 [thread overview]
Message-ID: <20071203232428.GF27094@coraid.com> (raw)
In-Reply-To: <20071203144722.4188f476.akpm@linux-foundation.org>
On Mon, Dec 03, 2007 at 02:47:22PM -0800, Andrew Morton wrote:
> On Mon, 3 Dec 2007 16:38:37 -0500
> "Ed L. Cashin" <ecashin@coraid.com> wrote:
...
> > It appears that the fbc->counters pointer is NULL.
>
> Does this fix?
>
> --- a/drivers/block/aoe/aoeblk.c~a
> +++ a/drivers/block/aoe/aoeblk.c
> @@ -6,6 +6,7 @@
>
> #include <linux/hdreg.h>
> #include <linux/blkdev.h>
> +#include <linux/backing-dev.h>
> #include <linux/fs.h>
> #include <linux/ioctl.h>
> #include <linux/genhd.h>
> @@ -228,6 +229,7 @@ aoeblk_gdalloc(void *vp)
>
> spin_lock_irqsave(&d->lock, flags);
> blk_queue_make_request(&d->blkq, aoeblk_make_request);
> + bdi_init(&d->blkq.backing_dev_info);
> gd->major = AOE_MAJOR;
> gd->first_minor = d->sysminor * AOE_PARTITIONS;
> gd->fops = &aoe_bdops;
> _
>
>
> <wonders whether blk_queue_make_request() should be running bdi_init()?>
No, the behavior doesn't change with this patch applied.
Meanwhile I have started a git bisect, and hopefully that will turn up
a specific patch before I hit an unbootable kernel or get my machine
in a state where it won't boot.
--
Ed L Cashin <ecashin@coraid.com>
prev parent reply other threads:[~2007-12-03 23:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-9482-10286@http.bugzilla.kernel.org/>
2007-12-01 20:23 ` [Bugme-new] [Bug 9482] New: kernel GPF in 2.6.24 (g09f345da) Andrew Morton
2007-12-01 21:05 ` Jon Nelson
2007-12-02 16:56 ` Jon Nelson
2007-12-03 16:21 ` Ed L. Cashin
2007-12-03 19:34 ` Andrew Morton
2007-12-03 21:00 ` Ed L. Cashin
2007-12-03 21:38 ` Ed L. Cashin
2007-12-03 22:47 ` Andrew Morton
2007-12-03 23:13 ` Andrew Morton
2007-12-03 23:42 ` Ed L. Cashin
2007-12-08 22:59 ` Jon Nelson
2007-12-09 3:50 ` Andrew Morton
2007-12-10 15:23 ` Ed L. Cashin
2007-12-03 23:24 ` Ed L. Cashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071203232428.GF27094@coraid.com \
--to=ecashin@coraid.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=bugme-daemon@bugzilla.kernel.org \
--cc=clameter@sgi.com \
--cc=jnelson-kernel-bugzilla@jamponi.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).