linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] x86_64: define all _PAGE_* in terms of _PAGE_BIT_*
Date: Tue, 4 Dec 2007 13:38:09 +0100	[thread overview]
Message-ID: <20071204123809.GD27286@elte.hu> (raw)
In-Reply-To: <11966016814058-git-send-email-joerg.roedel@amd.com>


* Joerg Roedel <joerg.roedel@amd.com> wrote:

> +#define _PAGE_PRESENT	(_AC(1,UL)<<_PAGE_BIT_PRESENT)

please run patches through scripts/checkpatch.pl, it gives:

  total: 10 errors, 0 warnings, 42 lines checked

(please send a followup cleanup patch - i picked up your series and this 
is a minor cleanliness issue)

	Ingo

  parent reply	other threads:[~2007-12-04 12:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-02 13:21 [PATCH 0/3] x86_64: some minor paging cleanups Joerg Roedel
2007-12-02 13:21 ` [PATCH 1/3] x86_64: define all _PAGE_* in terms of _PAGE_BIT_* Joerg Roedel
2007-12-04 12:36   ` Ingo Molnar
2007-12-04 12:38   ` Ingo Molnar [this message]
2007-12-04 15:06     ` Joerg Roedel
2007-12-04 21:07       ` Ingo Molnar
2007-12-05 10:52         ` Joerg Roedel
2007-12-05 11:27           ` Ingo Molnar
2007-12-05 11:42             ` Joerg Roedel
2007-12-05 12:30               ` Ingo Molnar
2007-12-05 14:40                 ` [PATCH] x86_64: some whitespace cleanups in paging code Joerg Roedel
2007-12-05 14:51                   ` Ingo Molnar
2007-12-05 16:37                   ` Heiko Carstens
2007-12-05 17:24                     ` Joerg Roedel
2007-12-02 13:21 ` [PATCH 2/3] x86_64: use __PAGE_KERNEL* instead of _KERNPG_TABLE for 2MB PTEs in memory initialization Joerg Roedel
2007-12-02 13:21 ` [PATCH 3/3] x86_64: use __PAGE_KERNEL_EXEC in ioremap_64.c Joerg Roedel
2007-12-04 15:23 [PATCH 0/3] x86_64: some minor paging cleanups Joerg Roedel
2007-12-04 15:23 ` [PATCH 1/3] x86_64: define all _PAGE_* in terms of _PAGE_BIT_* Joerg Roedel
2007-12-04 18:20   ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071204123809.GD27286@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=joerg.roedel@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).