Re: Allow (O=...) from file

From: Erik Mouw <mouw@nl.linux.org>
To: Jay Cliburn <jacliburn@bellsouth.net>
Cc: sam@ravnborg.org, linux-kernel@vger.kernel.org
Subject: Re: Allow (O=...) from file
Date: Wed, 5 Dec 2007 21:02:43 +0100	[thread overview]
Message-ID: <20071205200242.GB3995@gateway.home> (raw)
In-Reply-To: <20071204210433.4d7ee66c@osprey.hogchain.net>

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On Tue, Dec 04, 2007 at 09:04:33PM -0600, Jay Cliburn wrote:
> Sam,
> 
> This piece of the top-level Makefile in current git causes an
> out-of-tree driver Makefile to fail.
> 
> 101 ifdef O
> 102   ifeq ("$(origin O)", "command line")
> 103     KBUILD_OUTPUT := $(O)
> 104   endif
> 105 endif
> 
> The out-of-tree driver Makefile contains an O=... directive that
> (correctly) does _not_ specify the kernel source dir, and apparently
> isn't overridden by the command line either. If in the above Makefile
> snippet I change "command line" to "file", my out-of-tree make
> succeeds. What do you think about allowing O= to come from a file in
> addition to the command line?

Oh great, changing "command line" to "file" fixes my problem as well
(see http://lkml.org/lkml/2007/11/19/146 ). "make targz-pkg" works
flawless again.

Erik

-- 
They're all fools. Don't worry. Darwin may be slow, but he'll
eventually get them. -- Matthew Lammers in alt.sysadmin.recovery

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]