From: Andrew Morton <akpm@linux-foundation.org>
To: Jeff Dike <jdike@addtoit.com>
Cc: linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/6] UML - Customize tlb.h
Date: Thu, 6 Dec 2007 11:46:42 -0800 [thread overview]
Message-ID: <20071206114642.555a0749.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071206170640.GA7420@c2.user-mode-linux.org>
On Thu, 6 Dec 2007 12:06:40 -0500
Jeff Dike <jdike@addtoit.com> wrote:
> Customize the hooks in tlb.h to optimize TLB flushing some more.
>
> Add start and end fields to tlb_gather_mmu, which are used to limit
> the address space range scanned when a region is unmapped.
>
> The interfaces which just free page tables, without actually changing
> mappings, don't need to cause a TLB flush.
>
> ...
>
> +void flush_tlb_mm(struct mm_struct *mm)
> +{
> + struct vm_area_struct *vma = mm->mmap;
> +
> + if (atomic_read(&mm->mm_users) == 0)
> + return;
Under which circumstances does this test succeed?
> + while (vma != NULL) {
> + fix_range(mm, vma->vm_start, vma->vm_end, 0);
> + vma = vma->vm_next;
> + }
> }
>
> void force_flush_all(void)
> Index: linux-2.6-git/include/asm-um/tlb.h
> ===================================================================
> --- linux-2.6-git.orig/include/asm-um/tlb.h 2007-12-06 10:34:31.000000000 -0500
> +++ linux-2.6-git/include/asm-um/tlb.h 2007-12-06 10:58:34.000000000 -0500
> @@ -1,6 +1,125 @@
> #ifndef __UM_TLB_H
> #define __UM_TLB_H
>
> -#include <asm/arch/tlb.h>
> +#include <linux/swap.h>
> +#include <asm/pgalloc.h>
> +#include <asm/tlbflush.h>
> +
> +#define tlb_start_vma(tlb, vma) do { } while (0)
> +#define tlb_end_vma(tlb, vma) do { } while (0)
> +#define tlb_flush(tlb) flush_tlb_mm((tlb)->mm)
> +
> +/* struct mmu_gather is an opaque type used by the mm code for passing around
> + * any data needed by arch specific code for tlb_remove_page.
> + */
> +struct mmu_gather {
> + struct mm_struct *mm;
> + unsigned int need_flush; /* Really unmapped some ptes? */
> + unsigned long start;
> + unsigned long end;
> + unsigned int fullmm; /* non-zero means full mm flush */
> +};
> +
> +/* Users of the generic TLB shootdown code must declare this storage space. */
> +DECLARE_PER_CPU(struct mmu_gather, mmu_gathers);
> +
> +static inline void __tlb_remove_tlb_entry(struct mmu_gather *tlb, pte_t *ptep,
> + unsigned long address)
> +{
> + if (tlb->start > address)
> + tlb->start = address;
> + if (tlb->end < address + PAGE_SIZE)
> + tlb->end = address + PAGE_SIZE;
> +}
> +
> +static inline void init_tlb_gather(struct mmu_gather *tlb)
> +{
> + tlb->need_flush = 0;
> +
> + tlb->start = TASK_SIZE;
> + tlb->end = 0;
> +
> + if (tlb->fullmm) {
> + tlb->start = 0;
> + tlb->end = TASK_SIZE;
> + }
> +}
> +
> +/* tlb_gather_mmu
> + * Return a pointer to an initialized struct mmu_gather.
> + */
> +static inline struct mmu_gather *
> +tlb_gather_mmu(struct mm_struct *mm, unsigned int full_mm_flush)
> +{
> + struct mmu_gather *tlb = &get_cpu_var(mmu_gathers);
> +
> + tlb->mm = mm;
> + tlb->fullmm = full_mm_flush;
> +
> + init_tlb_gather(tlb);
> +
> + return tlb;
> +}
This file rather needs an inclusion of percpu.h. I guess you got lucky.
next prev parent reply other threads:[~2007-12-06 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 17:06 [PATCH 1/6] UML - Customize tlb.h Jeff Dike
2007-12-06 19:46 ` Andrew Morton [this message]
2007-12-06 20:19 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071206114642.555a0749.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).