From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753879AbXLFTuV (ORCPT ); Thu, 6 Dec 2007 14:50:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751684AbXLFTuJ (ORCPT ); Thu, 6 Dec 2007 14:50:09 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:39714 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbXLFTuI (ORCPT ); Thu, 6 Dec 2007 14:50:08 -0500 Date: Thu, 6 Dec 2007 10:50:06 -0800 From: Greg KH To: Balbir Singh Cc: Kamalesh Babulal , Andrew Morton , linux-kernel@vger.kernel.org, rsa@us.ibm.com, apw@shadowen.org, balbir@in.ibm.com Subject: Re: 2.6.24-rc4-mm1 kobject changes broken with hvcs driver on powerpc Message-ID: <20071206185006.GA21641@kroah.com> References: <20071204211701.994dfce6.akpm@linux-foundation.org> <20071205141202.GB13189@linux.vnet.ibm.com> <47583D4F.2050707@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47583D4F.2050707@linux.vnet.ibm.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 06, 2007 at 11:49:59PM +0530, Balbir Singh wrote: > Kamalesh Babulal wrote: > > Hi Andrew, > > > > The 2.6.24-rc4-mm1 kernel build fails with build failure, > > > > CC drivers/char/hvcs.o > > drivers/char/hvcs.c: In function ‘hvcs_open’: > > drivers/char/hvcs.c:1180: error: wrong type argument to unary exclamation mark > > make[2]: *** [drivers/char/hvcs.o] Error 1 > > make[1]: *** [drivers/char] Error 2 > > make: *** [drivers] Error 2 > > > > The kref_get begin void return type, check for the kobject return type > > as in the previous kobject_get() > > > > if (!kref_get(&hvcsd->kref)) { > > spin_unlock_irqrestore(&hvcsd->lock, flags); > > printk(KERN_ERR "HVCS: Kobject of open" > > " hvcs doesn't exist.\n"); > > return -EFAULT; /* Is this the right return value? */ > > } > > > > I have tested for the build failure only. > > > > Signed-off-by: Kamalesh Babulal > > -- > > --- linux-2.6.24-rc4/drivers/char/hvcs.c 2007-12-05 12:17:37.000000000 +0530 > > +++ linux-2.6.24-rc4/drivers/char/~hvcs.c 2007-12-05 19:17:12.000000000 +0530 > > @@ -1177,12 +1177,8 @@ fast_open: > > hvcsd = tty->driver_data; > > > > spin_lock_irqsave(&hvcsd->lock, flags); > > - if (!kref_get(&hvcsd->kref)) { > > - spin_unlock_irqrestore(&hvcsd->lock, flags); > > - printk(KERN_ERR "HVCS: Kobject of open" > > - " hvcs doesn't exist.\n"); > > - return -EFAULT; /* Is this the right return value? */ > > - } > > + kref_get(&hvcsd->kref); > > + spin_unlock_irqrestore(&hvcsd->lock, flags); > > > > Why release the spinlock here? It's done after the count is incremented. > This patch does not seem correct. Doh, you are correct, I'll make sure that I fix this up before applying it. thanks, greg k-h