From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754121AbXLFVHY (ORCPT ); Thu, 6 Dec 2007 16:07:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752704AbXLFVHM (ORCPT ); Thu, 6 Dec 2007 16:07:12 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:50531 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752693AbXLFVHL (ORCPT ); Thu, 6 Dec 2007 16:07:11 -0500 Date: Thu, 6 Dec 2007 22:07:08 +0100 From: Adrian Bunk To: Andrew Morton Cc: penguin-kernel@I-love.SAKURA.ne.jp, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Add EXPORT_SYMBOL(ksize); Message-ID: <20071206210708.GO15974@stusta.de> References: <200712021743.GBH12983.FHOFVJOMFLOStQ@I-love.SAKURA.ne.jp> <20071202134841.GI15974@stusta.de> <20071203153459.ac19dae3.akpm@linux-foundation.org> <20071206210248.GN15974@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20071206210248.GN15974@stusta.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 06, 2007 at 10:02:48PM +0100, Adrian Bunk wrote: > On Mon, Dec 03, 2007 at 03:34:59PM -0800, Andrew Morton wrote: > > On Sun, 2 Dec 2007 14:48:42 +0100 > > Adrian Bunk wrote: > > > > > On Sun, Dec 02, 2007 at 05:43:39PM +0900, Tetsuo Handa wrote: > > > > > > > > mm/slub.c exports ksize(), but mm/slob.c and mm/slab.c don't. I don't know why. > > > >... > > > > > > That's due to the fact that my patch to remove this unused export from > > > slub was not yet applied... > > > > > > Where is the modular in-kernel user? > > > > > > > binfmt_flat.c, binfmt_elf_fdpic.c. > > I could have sworn I had checked that both are bools, but BINFMT_FLAT is > actually a tristate. > > Is anyone actually using binfmt_flat modular (considering it's only > available for !MMU embedded systems)? If yes, then only exporting > ksize() will not be enough for getting it working modular... Considering it even lacks a MODULE_LICENSE("GPL") I do very much suspect it simply lacks any use case. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed