linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: rct@frus.com (Bob Tracy)
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Bob Tracy <rct@frus.com>,
	mingo@elte.hu, mcree@orcon.net.nz, linux-kernel@vger.kernel.org,
	rjw@sisk.pl, rth@twiddle.net, ink@jurassic.park.msu.ru,
	linux-scsi@vger.kernel.org, kay.sievers@vrfy.org, greg@kroah.com
Subject: Re: [BUG] 2.6.23-rc3 can't see sd partitions on Alpha
Date: Fri, 7 Dec 2007 07:39:03 -0600 (CST)	[thread overview]
Message-ID: <20071207133904.346FDDBA2@gherkin.frus.com> (raw)
In-Reply-To: <20071207022646.373c92f5.akpm@linux-foundation.org> "from Andrew Morton at Dec 7, 2007 02:26:46 am"

Andrew Morton wrote:
> On Thu, 6 Dec 2007 23:07:08 -0600 (CST) rct@frus.com (Bob Tracy) wrote:
> > Andrew Morton wrote:
> > > commit 6f37ac793d6ba7b35d338f791974166f67fdd9ba
> > > Merge: 2f1f53b... d90bf5a...
> > > Author: Linus Torvalds <torvalds@woody.linux-foundation.org>
> > > Date:   Wed Nov 14 18:51:48 2007 -0800
> > > 
> > >     Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/n
> > >     
> > >     * 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6:
> > >       (omitted for brevity)
> > > 
> > > I'm struggling to see how any of those could have broken block device
> > > mounting on alpha.  Are you sure you bisected right?
> > 
> > Based on what's in that commit, it *does* appear something went wrong
> > with bisection.  If the implicated commit is the next one in time
> > sequence relative to
> > 
> > # good: [2f1f53bdc6531696934f6ee7bbdfa2ab4f4f62a3] CRISv10 fasttimer: Scrap INLINE and name timeval_cmp better
> > 
> > then the test of whether I bisected correctly is as simple as applying
> > the commit and seeing if things break, because I'm running on the
> > kernel corresponding to 2f1f53bdc6531696934f6ee7bbdfa2ab4f4f62a3 right
> > now.  Let me give that a try and I'll report back.  Worst case, I'll
> > have to start over and write off the past four days...
> 
> Gad.  I trust the second time will be faster.
> 
> git-bisect _is_ very error prone.  I find one of the problems is that each
> step is so far apart in time that you forget what you were doing.  Did I
> remember to test that iteration?  Did I install the right kernel?  etc.
> 
> > Sorry about this...
> 
> Not appropriate ;)   Thanks for helping out.

Thanks for the kind words...  The above-mentioned test verified that the
bisection was/is correct: 2f1f53bdc6531696934f6ee7bbdfa2ab4f4f62a3 works,
and 6f37ac793d6ba7b35d338f791974166f67fdd9ba doesn't.  Now I've got to
figure out why.

"git diff 2f1f53bdc6531696934f6ee7bbdfa2ab4f4f62a3 6f37ac793d6ba7b35d338f791974166f67fdd9ba"
produced a relatively short patch (18,437 bytes).  The list of involved
files:

diff --git a/drivers/char/random.c b/drivers/char/random.c
diff --git a/drivers/isdn/sc/card.h b/drivers/isdn/sc/card.h
diff --git a/drivers/isdn/sc/packet.c b/drivers/isdn/sc/packet.c
diff --git a/drivers/isdn/sc/shmem.c b/drivers/isdn/sc/shmem.c
diff --git a/drivers/net/arm/ep93xx_eth.c b/drivers/net/arm/ep93xx_eth.c
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
diff --git a/drivers/net/fs_enet/Kconfig b/drivers/net/fs_enet/Kconfig
diff --git a/drivers/net/fs_enet/Makefile b/drivers/net/fs_enet/Makefile
diff --git a/drivers/net/netx-eth.c b/drivers/net/netx-eth.c
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
diff --git a/include/net/sock.h b/include/net/sock.h
diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c
diff --git a/net/core/dev.c b/net/core/dev.c
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c

Current state of the source tree is the 6f37ac... version, so I'll start
backing out the above diffs in related groups and continue until I've got
a working kernel.  For lack of an obvious target, I'll start with the
seemingly innocuous change to sysctl_check.c.  I'll report back when I've
got something.

-- 
------------------------------------------------------------------------
Bob Tracy          |  "They couldn't hit an elephant at this dist- "
rct@frus.com       |   - Last words of Union General John Sedgwick,
                   |  Battle of Spotsylvania Court House, U.S. Civil War
------------------------------------------------------------------------

  parent reply	other threads:[~2007-12-07 13:39 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-18  5:20 [BUG] 2.6.23-rc3 can't see sd partitions on Alpha Bob Tracy
2007-11-25  6:38 ` Andrew Morton
2007-11-25 12:15   ` Rafael J. Wysocki
2007-11-26 13:48   ` Bob Tracy
2007-11-30 22:30     ` Michael Cree
2007-11-30 22:42       ` Andrew Morton
2007-11-30 23:26         ` Rafael J. Wysocki
2007-12-02 20:53         ` Michael Cree
2007-12-03  1:17           ` Bob Tracy
2007-12-04 12:16             ` Ingo Molnar
2007-12-04 15:36               ` Bob Tracy
2007-12-05 17:30               ` Bob Tracy
2007-12-07  0:16               ` Bob Tracy
2007-12-07  0:33                 ` Andrew Morton
2007-12-07  5:07                   ` Bob Tracy
2007-12-07 10:26                     ` Andrew Morton
2007-12-07 11:37                       ` Ingo Molnar
2007-12-07 13:39                       ` Bob Tracy [this message]
2007-12-07 14:55                       ` Bob Tracy
2007-12-07 15:05                         ` Ingo Molnar
2007-12-07 16:59                           ` Bob Tracy
2007-12-07 18:06                             ` Ingo Molnar
2007-12-07 18:19                               ` Kay Sievers
2007-12-07 19:36                                 ` Bob Tracy
2007-12-07 20:43                         ` Michael Cree
2007-12-07 21:19                           ` Kay Sievers
2007-12-07 22:39                             ` Bob Tracy
2007-12-08  4:53                             ` Bob Tracy
2007-12-08  5:05                             ` Bob Tracy
2007-12-08 15:48                               ` Kay Sievers
2007-12-09  0:51                                 ` Michael Cree
2007-12-09  4:19                                   ` Bob Tracy
2007-12-09 18:07                                     ` Ivan Kokshaysky
2007-12-10 15:08                                       ` Bob Tracy
2007-12-10 23:12                                         ` Ivan Kokshaysky
2007-12-10 15:05                                 ` Bob Tracy
2007-12-07 11:40                     ` Ingo Molnar
2007-12-07  5:42                   ` Bob Tracy
2007-12-07  9:33                   ` Ingo Molnar
2007-12-07  0:44                 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071207133904.346FDDBA2@gherkin.frus.com \
    --to=rct@frus.com \
    --cc=akpm@linux-foundation.org \
    --cc=greg@kroah.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mcree@orcon.net.nz \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).