From: Pierre Ossman <drzeus@drzeus.cx>
To: Nicolas Pitre <nico@cam.org>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: remove unused 'mode' from the mmc_host structure
Date: Sun, 9 Dec 2007 18:01:21 +0100 [thread overview]
Message-ID: <20071209180121.22b5948b@poseidon.drzeus.cx> (raw)
In-Reply-To: <alpine.LFD.0.99999.0712062257310.555@xanadu.home>
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
On Thu, 06 Dec 2007 23:12:46 -0500 (EST)
Nicolas Pitre <nico@cam.org> wrote:
> This field and corresponding defines are simply never used anywhere
> in the code. But its mere presence is enough to confuse some host
> driver authors who attempt to rely on it. Let's eliminate the
> possibility for confusion and remove it entirely.
>
> Signed-off-by: Nicolas Pitre <nico@cam.org>
> ---
Oopsie. Some old stuff since before the restructuring.
>
> yes, it's the second host driver I'm reviewing with this issue...
>
Seems to be a bit of Windows mentality that spills over. Maybe you should give them a quick tutorial in that in Linux we fix stuff at the source. ;)
Thanks for the patch. I've queued it up.
Rgds
Pierre
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2007-12-09 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-07 4:12 [PATCH] mmc: remove unused 'mode' from the mmc_host structure Nicolas Pitre
2007-12-09 17:01 ` Pierre Ossman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071209180121.22b5948b@poseidon.drzeus.cx \
--to=drzeus@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).