From: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
To: Charlie Brady <charlieb@budge.apana.org.au>
Cc: linux-ppp@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PPP synchronous tty: convert dead_sem to completion
Date: Sun, 9 Dec 2007 20:53:01 +0100 [thread overview]
Message-ID: <20071209195301.GF15658@traven> (raw)
In-Reply-To: <Pine.LNX.4.64.0712091203490.976@e-smith.charlieb.ott.istop.com>
El Sun, Dec 09, 2007 at 12:04:48PM -0500 Charlie Brady ha dit:
>
> On Sat, 8 Dec 2007, Matthias Kaehlcke wrote:
>
>> PPP synchronous tty channel driver: convert the semaphore dead_sem to
>> a completion
>>
>> Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
>
> Excuse my ignorance please, but why is this a good idea? Should we not
> record the reason for changes?
Semaphores can be used to signal completion of a job, but aren't the
optimal way to do so. According to LDD3 semaphores are optimized for
the 'available' case and performance suffers when using them as
completion.
It is also clearer to use each synchronization mechanism according to
its purpose, i.e. semaphores for protection of critical sections and
completions for signalling that a job is done.
--
Matthias Kaehlcke
Linux System Developer
Barcelona
You can't separate peace from freedom because no
one can be at peace unless he has his freedom
(Malcolm X)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
prev parent reply other threads:[~2007-12-09 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-08 15:09 [PATCH] PPP synchronous tty: convert dead_sem to completion Matthias Kaehlcke
2007-12-09 17:04 ` Charlie Brady
2007-12-09 19:53 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071209195301.GF15658@traven \
--to=matthias.kaehlcke@gmail.com \
--cc=charlieb@budge.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).