From: Pavel Machek <pavel@ucw.cz>
To: Andi Kleen <andi@firstfloor.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
"David P. Reed" <dpreed@reed.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: RFC: outb 0x80 in inb_p, outb_p harmful on some modern AMD64 with MCP51 laptops
Date: Sun, 9 Dec 2007 22:25:13 +0100 [thread overview]
Message-ID: <20071209212513.GC24284@elf.ucw.cz> (raw)
In-Reply-To: <20071209165908.GA15910@one.firstfloor.org>
On Sun 2007-12-09 17:59:08, Andi Kleen wrote:
> > I mean, we expect 8usec delay -- historical ISA timing -- but when
> > _PCI_ card with leds is inserted, it is likely to be faster than old
> > ISA, right?
>
> Yes, i guess switching to udelay at least on newer systems would
> be a good idea. I'm not quite sure about systems without TSC though.
Something like this? (Warning, will not probably even compile on
x86-64, I do not have 64-bit compiler near me).
(I believe VGA cards do not need slow outputs, plus udelay is not
available in uncompressor?)
Signed-off-by: Pavel Machek <pavel@suse.cz> [but it needs fixing x86-64]
Pavel
diff --git a/arch/x86/boot/compressed/misc_32.c b/arch/x86/boot/compressed/misc_32.c
index b74d60d..288e162 100644
--- a/arch/x86/boot/compressed/misc_32.c
+++ b/arch/x86/boot/compressed/misc_32.c
@@ -276,10 +276,10 @@ static void putstr(const char *s)
RM_SCREEN_INFO.orig_y = y;
pos = (x + cols * y) * 2; /* Update cursor position */
- outb_p(14, vidport);
- outb_p(0xff & (pos >> 9), vidport+1);
- outb_p(15, vidport);
- outb_p(0xff & (pos >> 1), vidport+1);
+ outb(14, vidport);
+ outb(0xff & (pos >> 9), vidport+1);
+ outb(15, vidport);
+ outb(0xff & (pos >> 1), vidport+1);
}
static void* memset(void* s, int c, unsigned n)
diff --git a/include/asm-x86/io_32.h b/include/asm-x86/io_32.h
index fe881cd..944dc5f 100644
--- a/include/asm-x86/io_32.h
+++ b/include/asm-x86/io_32.h
@@ -3,6 +3,7 @@ #define _ASM_IO_H
#include <linux/string.h>
#include <linux/compiler.h>
+#include <linux/delay.h>
/*
* This file contains the definitions for the x86 IO instructions
@@ -17,17 +18,6 @@ #include <linux/compiler.h>
* mistake somewhere.
*/
-/*
- * Thanks to James van Artsdalen for a better timing-fix than
- * the two short jumps: using outb's to a nonexistent port seems
- * to guarantee better timings even on fast machines.
- *
- * On the other hand, I'd like to be sure of a non-existent port:
- * I feel a bit unsafe about using 0x80 (should be safe, though)
- *
- * Linus
- */
-
/*
* Bit simplified and optimized by Jan Hubicka
* Support of BIGMEM added by Gerhard Wichert, Siemens AG, July 1999.
@@ -252,7 +242,7 @@ #endif /* __KERNEL__ */
static inline void native_io_delay(void)
{
- asm volatile("outb %%al,$0x80" : : : "memory");
+ udelay(8);
}
#if defined(CONFIG_PARAVIRT)
diff --git a/include/asm-x86/io_64.h b/include/asm-x86/io_64.h
index a037b07..6dd5ed3 100644
--- a/include/asm-x86/io_64.h
+++ b/include/asm-x86/io_64.h
@@ -1,6 +1,7 @@
#ifndef _ASM_IO_H
#define _ASM_IO_H
+#include <linux/delay.h>
/*
* This file contains the definitions for the x86 IO instructions
@@ -15,17 +16,6 @@ #define _ASM_IO_H
* mistake somewhere.
*/
-/*
- * Thanks to James van Artsdalen for a better timing-fix than
- * the two short jumps: using outb's to a nonexistent port seems
- * to guarantee better timings even on fast machines.
- *
- * On the other hand, I'd like to be sure of a non-existent port:
- * I feel a bit unsafe about using 0x80 (should be safe, though)
- *
- * Linus
- */
-
/*
* Bit simplified and optimized by Jan Hubicka
* Support of BIGMEM added by Gerhard Wichert, Siemens AG, July 1999.
@@ -35,12 +25,10 @@ #define _ASM_IO_H
* - Arnaldo Carvalho de Melo <acme@conectiva.com.br>
*/
-#define __SLOW_DOWN_IO "\noutb %%al,$0x80"
-
#ifdef REALLY_SLOW_IO
-#define __FULL_SLOW_DOWN_IO __SLOW_DOWN_IO __SLOW_DOWN_IO __SLOW_DOWN_IO __SLOW_DOWN_IO
+#define P_DELAY 40
#else
-#define __FULL_SLOW_DOWN_IO __SLOW_DOWN_IO
+#define P_DELAY 8
#endif
/*
@@ -54,7 +42,7 @@ __asm__ __volatile__ ("out" #s " %" s1 "
#define __OUT(s,s1,x) \
__OUT1(s,x) __OUT2(s,s1,"w") : : "a" (value), "Nd" (port)); } \
-__OUT1(s##_p,x) __OUT2(s,s1,"w") __FULL_SLOW_DOWN_IO : : "a" (value), "Nd" (port));} \
+__OUT1(s##_p,x) __OUT2(s,s1,"w") : : "a" (value), "Nd" (port));} udelay(P_DELAY); \
#define __IN1(s) \
static inline RETURN_TYPE in##s(unsigned short port) { RETURN_TYPE _v;
@@ -64,7 +52,7 @@ __asm__ __volatile__ ("in" #s " %" s2 "1
#define __IN(s,s1,i...) \
__IN1(s) __IN2(s,s1,"w") : "=a" (_v) : "Nd" (port) ,##i ); return _v; } \
-__IN1(s##_p) __IN2(s,s1,"w") __FULL_SLOW_DOWN_IO : "=a" (_v) : "Nd" (port) ,##i ); return _v; } \
+__IN1(s##_p) __IN2(s,s1,"w") : "=a" (_v) : "Nd" (port) ,##i ); udelay(P_DELAY); return _v; } \
#define __INS(s) \
static inline void ins##s(unsigned short port, void * addr, unsigned long count) \
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-12-09 21:24 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 22:38 RFC: outb 0x80 in inb_p, outb_p harmful on some modern AMD64 with MCP51 laptops David P. Reed
2007-12-07 0:15 ` Alan Cox
2007-12-07 10:44 ` Andi Kleen
2007-12-07 14:50 ` David P. Reed
2007-12-05 11:10 ` Pavel Machek
2007-12-08 0:21 ` Andi Kleen
2007-12-07 14:54 ` Andi Kleen
2007-12-07 15:43 ` Rene Herman
2007-12-07 16:28 ` Rene Herman
2007-12-11 0:31 ` H. Peter Anvin
2007-12-11 5:53 ` H. Peter Anvin
2007-12-07 16:04 ` Alan Cox
2007-12-07 16:31 ` Andi Kleen
2007-12-07 17:19 ` Alan Cox
2007-12-07 18:45 ` Rene Herman
2007-12-07 18:42 ` Alan Cox
2007-12-07 19:25 ` Rene Herman
2007-12-07 21:45 ` Alan Cox
2007-12-08 19:25 ` David P. Reed
2007-12-08 19:50 ` Andi Kleen
2007-12-08 20:47 ` David P. Reed
2007-12-08 21:04 ` Alan Cox
2007-12-08 20:26 ` Alan Cox
2007-12-11 5:58 ` H. Peter Anvin
2007-12-09 5:04 ` Rene Herman
2007-12-09 13:22 ` Pavel Machek
2007-12-11 15:14 ` Lennart Sorensen
2007-12-09 12:54 ` Pavel Machek
2007-12-09 13:41 ` Dr. David Alan Gilbert
2007-12-09 15:54 ` Ondrej Zary
2007-12-09 16:59 ` Andi Kleen
2007-12-09 21:25 ` Pavel Machek [this message]
2007-12-09 22:29 ` Alan Cox
2007-12-09 23:22 ` Pavel Machek
2007-12-10 12:02 ` Alan Cox
2007-12-10 4:17 ` Rene Herman
2007-12-10 11:30 ` Krzysztof Halasa
2007-12-10 12:08 ` Rene Herman
2007-12-10 18:02 ` Ondrej Zary
2007-12-11 1:10 ` David Newall
2007-12-11 1:25 ` H. Peter Anvin
2007-12-11 1:42 ` David Newall
2007-12-11 1:46 ` H. Peter Anvin
2007-12-11 1:51 ` H. Peter Anvin
2007-12-11 7:40 ` Paul Rolland
2007-12-11 9:50 ` Rene Herman
2007-12-11 12:08 ` David Newall
2007-12-11 13:16 ` Rene Herman
2007-12-11 13:32 ` Paul Rolland
2007-12-11 14:15 ` Rene Herman
2007-12-11 15:28 ` Rene Herman
2007-12-11 15:37 ` Paul Rolland
2007-12-11 15:53 ` Rene Herman
2007-12-11 16:58 ` David P. Reed
2007-12-11 17:01 ` Rene Herman
2007-12-11 17:05 ` H. Peter Anvin
2007-12-11 17:32 ` Alan Cox
2007-12-11 19:19 ` David P. Reed
2007-12-11 19:36 ` Pavel Machek
2007-12-11 20:16 ` Alan Cox
2007-12-11 20:27 ` linux-os (Dick Johnson)
2007-12-11 20:34 ` Rene Herman
2007-12-11 21:03 ` David P. Reed
2007-12-11 23:56 ` David P. Reed
2007-12-12 13:11 ` linux-os (Dick Johnson)
2007-12-12 16:12 ` Alan Cox
2007-12-14 14:33 ` Ingo Molnar
2007-12-16 21:26 ` Pavel Machek
2007-12-17 0:02 ` Alan Cox
2007-12-17 0:03 ` Alan Cox
2007-12-17 0:28 ` Pavel Machek
2007-12-17 14:42 ` Ingo Molnar
2007-12-27 10:39 ` Pavel Machek
2007-12-12 19:42 ` Attitude problems David P. Reed
2007-12-12 20:31 ` linux-os (Dick Johnson)
2007-12-14 16:01 ` linux-os (Dick Johnson)
2007-12-11 16:32 ` RFC: outb 0x80 in inb_p, outb_p harmful on some modern AMD64 with MCP51 laptops John Stoffel
2007-12-11 16:40 ` Rene Herman
2007-12-11 13:50 ` David Newall
2007-12-11 14:14 ` Rene Herman
2007-12-11 14:25 ` Alan Cox
2007-12-12 22:18 ` David Newall
2007-12-12 23:00 ` Alan Cox
2007-12-13 13:13 ` David P. Reed
2007-12-13 13:21 ` Alan Cox
2007-12-14 1:50 ` David P. Reed
2007-12-14 15:16 ` Alan Cox
2007-12-11 15:41 ` linux-os (Dick Johnson)
2007-12-11 16:30 ` Andi Kleen
2007-12-11 16:50 ` Rene Herman
2007-12-11 17:00 ` David P. Reed
2007-12-11 17:04 ` Rene Herman
2007-12-11 17:27 ` Rene Herman
2007-12-11 19:18 ` Pavel Machek
2007-12-11 19:16 ` Pavel Machek
2007-12-11 19:59 ` Rene Herman
2007-12-11 19:59 ` Rene Herman
2007-12-11 20:00 ` Rene Herman
2007-12-11 20:00 ` Rene Herman
2007-12-12 20:07 ` More info on port 80 symptoms on MCP51 machine David P. Reed
2007-12-12 20:26 ` Rene Herman
2007-12-12 20:37 ` David P. Reed
2007-12-12 20:58 ` Rene Herman
2007-12-12 21:01 ` Alan Cox
2007-12-12 21:12 ` H. Peter Anvin
2007-12-12 21:29 ` Alan Cox
2007-12-15 22:34 ` Allen Martin
2007-12-15 22:46 ` H. Peter Anvin
2007-12-16 0:46 ` David P. Reed
2007-12-12 21:05 ` H. Peter Anvin
2007-12-14 22:05 ` Chuck Ebbert
2007-12-15 7:22 ` Rene Herman
2007-12-11 13:14 ` RFC: outb 0x80 in inb_p, outb_p harmful on some modern AMD64 with MCP51 laptops Alan Cox
2007-12-11 13:32 ` Andi Kleen
2007-12-11 13:47 ` Pavel Machek
2007-12-11 13:50 ` Andi Kleen
2007-12-14 13:33 ` Ingo Molnar
2007-12-11 6:54 ` Rene Herman
2007-12-11 17:01 ` H. Peter Anvin
[not found] <fa./27SNSh+L5T3iqFNPdHClEu+yT0@ifi.uio.no>
2007-12-07 0:23 ` Robert Hancock
2007-12-07 5:09 ` Rene Herman
2007-12-07 5:54 ` David P. Reed
2007-12-07 7:17 ` Rene Herman
2007-12-07 7:34 ` Rene Herman
2007-12-07 10:49 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071209212513.GC24284@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=dpreed@reed.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).