From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>,
Andrew Morton <akpm@linux-foundation.org>,
miltonm@bga.com, clameter@sgi.com, apw@shadowen.org,
linux-kernel@vger.kernel.org
Subject: Re: PS3: trouble with SPARSEMEM_VMEMMAP and kexec
Date: Mon, 10 Dec 2007 10:55:00 +0900 [thread overview]
Message-ID: <20071210104948.B6E8.Y-GOTO@jp.fujitsu.com> (raw)
In-Reply-To: <475A05A8.2050909@am.sony.com>
> Yasunori Goto wrote:
> >> On Thu, 6 Dec 2007, Geert Uytterhoeven wrote:
> >> > On Thu, 6 Dec 2007, Yasunori Goto wrote:
> >> > > > I'll try Milton's suggestion to pre-allocate the memory early. It seems
> >> > > > that should work as long as nothing else before the hot-plug mem is added
> >> > > > needs a large chunk.
> >> > >
> >> > > Hello. Geoff-san. Sorry for late response.
> >> > >
> >> > > Could you tell me the value of the following page_size calculation
> >> > > in vmemmap_populate()? I think this page_size may be too big value.
> >> > >
> >> > > ------
> >> > > int __meminit vmemmap_populate(struct page *start_page,
> >> > > unsigned long nr_pages, int node)
> >> > > :
> >> > > :
> >> > > unsigned long page_size = 1 << mmu_psize_defs[mmu_linear_psize].shift;
> >> > > :
> >> > > -------
> >>
> >> 16 MiB of course.
> >
> > 16 MiB is not page size. It is "section size".
> > IIRC, powerpc's page size must be 4K (or 64K).
> > If page size is 4k, vmemmap_alloc_block will call the order 12 page.
>
>
> By default PS3 uses 4K virtual pages, and 16M linear pages.
>
>
> > Is it really correct value for vmemmap population?
>
>
> It seems vmemmap needs linear pages, so I think it is ok.
Oh, I see. Sorry for noise.
Bye.
--
Yasunori Goto
next prev parent reply other threads:[~2007-12-10 1:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-03 3:59 PS3: trouble with SPARSEMEM_VMEMMAP and kexec Geoff Levand
2007-12-03 15:53 ` Milton Miller
2007-12-04 8:30 ` Geert Uytterhoeven
2007-12-05 4:56 ` Geoff Levand
2007-12-05 4:55 ` Geoff Levand
2007-12-05 9:52 ` Geert Uytterhoeven
2007-12-05 23:11 ` Andrew Morton
2007-12-05 23:45 ` Geoff Levand
2007-12-06 6:09 ` Yasunori Goto
2007-12-06 9:55 ` Geert Uytterhoeven
2007-12-06 9:55 ` Geert Uytterhoeven
2007-12-06 10:48 ` Yasunori Goto
2007-12-08 2:47 ` Geoff Levand
2007-12-10 1:55 ` Yasunori Goto [this message]
2007-12-08 3:26 ` Geoff Levand
2007-12-08 3:49 ` oops with 2.6.23.1, marvel, software raid, reiserfs and samba jeffunit
2007-12-16 11:05 ` Andrew Morton
2007-12-16 11:56 ` Herbert Xu
2007-12-16 12:21 ` Herbert Xu
2007-12-16 14:55 ` jeffunit
2007-12-16 22:09 ` Andrew Morton
2007-12-06 7:41 ` PS3: trouble with SPARSEMEM_VMEMMAP and kexec Geert Uytterhoeven
2007-12-07 5:55 ` Geoff Levand
2007-12-06 5:44 ` Geoff Levand
2007-12-09 4:22 ` sparsemem: Make SPARSEMEM_VMEMMAP selectable Geoff Levand
2007-12-10 5:50 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071210104948.B6E8.Y-GOTO@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=Geert.Uytterhoeven@sonycom.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=clameter@sgi.com \
--cc=geoffrey.levand@am.sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).