From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935932AbXLQLYq (ORCPT ); Mon, 17 Dec 2007 06:24:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935341AbXLQLYh (ORCPT ); Mon, 17 Dec 2007 06:24:37 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:44462 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764192AbXLQLYg (ORCPT ); Mon, 17 Dec 2007 06:24:36 -0500 Date: Mon, 17 Dec 2007 03:22:22 -0800 From: Andrew Morton To: Jiri Kosina Cc: David Sterba , linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org Subject: Re: [PATCH V2] ipwireless_cs driver for 4G PC Card Message-Id: <20071217032222.af86c830.akpm@linux-foundation.org> In-Reply-To: References: <20071130125555.GA10977@ds.suse.cz> <20071212150851.GB10118@ds.suse.cz> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Dec 2007 11:57:46 +0100 (CET) Jiri Kosina wrote: > [ CC list trimmed ] often a bad idea... > On Wed, 12 Dec 2007, David Sterba wrote: > > > Changelog: > > * files moved to ipwireless/, ipwireless_cs_ stripped from filenames > > * _cs stripped from driver name > > * kmalloc checks > > * sync irq during shutdown > > * removed /proc code, converted to module params > > > > When merged, please drop ipwireless_cs.git tree from -mm and > > include the patch instead. > > > > Regards, > > David Sterba > > > > Rewieved-by: Jiri Slaby > > Signed-off-by: Ben Martel > > Signed-off-by: Stephen Blackheath > > Signed-off-by: David Sterba > > Signed-off-by: Jiri Kosina > > --- > > MAINTAINERS | 8 > > drivers/char/pcmcia/Kconfig | 9 > > drivers/char/pcmcia/Makefile | 2 > > drivers/char/pcmcia/ipwireless/Makefile | 10 > > drivers/char/pcmcia/ipwireless/hardware.c | 1784 ++++++++++++++++++++++++ > > drivers/char/pcmcia/ipwireless/hardware.h | 63 > > drivers/char/pcmcia/ipwireless/main.c | 496 ++++++ > > drivers/char/pcmcia/ipwireless/main.h | 70 > > drivers/char/pcmcia/ipwireless/network.c | 513 ++++++ > > drivers/char/pcmcia/ipwireless/network.h | 54 > > drivers/char/pcmcia/ipwireless/setup_protocol.h | 108 + > > drivers/char/pcmcia/ipwireless/tty.c | 687 +++++++++ > > drivers/char/pcmcia/ipwireless/tty.h | 48 > > 13 files changed, 3852 insertions(+) > > Andrew, what is your position on merging this into your 2.6.25 queue > please? David has fixed all the issues that came up during review, so it > seems to be that it's time for the driver to be merged during the upcoming > merge window. > > If you take it, I am perfectly fine with you dropping the > ipwireless_cs git tree from -mm lineup. > I'd have thought that you'd merge it into git-ipwireless_cs.patch and that you would then take care of merging it into mainline at an appropriate time?