From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb/storage/initializers.c: fix signedness difference
Date: Wed, 19 Dec 2007 19:15:56 +0100 [thread overview]
Message-ID: <20071219181552.GA18104@joi> (raw)
In-Reply-To: <20071218153642.cf8c6a0b.akpm@linux-foundation.org>
On Tue, Dec 18, 2007 at 03:36:42PM -0800, Andrew Morton wrote:
> On Sun, 9 Dec 2007 22:23:42 +0100
> Marcin __lusarz <marcin.slusarz@gmail.com> wrote:
>
> > usb/storage/initializers.c: fix signedness difference
> >
> > Signed-off-by: Marcin __lusarz <marcin.slusarz@gmail.com>
> > ---
> > drivers/usb/storage/initializers.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/storage/initializers.c b/drivers/usb/storage/initializers.c
> > index ee5b42a..187dd1e 100644
> > --- a/drivers/usb/storage/initializers.c
> > +++ b/drivers/usb/storage/initializers.c
> > @@ -66,7 +66,8 @@ int usb_stor_ucr61s2b_init(struct us_data *us)
> > {
> > struct bulk_cb_wrap *bcb = (struct bulk_cb_wrap*) us->iobuf;
> > struct bulk_cs_wrap *bcs = (struct bulk_cs_wrap*) us->iobuf;
> > - int res, partial;
> > + int res;
> > + unsigned int partial;
> > static char init_string[] = "\xec\x0a\x06\x00$PCCHIPS";
> >
> > US_DEBUGP("Sending UCR-61S2B initialization packet...\n");
>
> Often we just wouldn't bother about something this minor.
>
> But I see later on that we pass the address of `partial' into some other
> function and I am guessing that this produces some warning with some tool
> which you didn't tell us about?
it fixed 2 sparse warnings:
drivers/usb/storage/initializers.c:83:26: warning: incorrect type in argument 5 (different signedness)
drivers/usb/storage/initializers.c:83:26: expected unsigned int *act_len
drivers/usb/storage/initializers.c:83:26: got int *<noident>
drivers/usb/storage/initializers.c:89:26: warning: incorrect type in argument 5 (different signedness)
drivers/usb/storage/initializers.c:89:26: expected unsigned int *act_len
drivers/usb/storage/initializers.c:89:26: got int *<noident>
After you pointed out that I should include warnings in patch description,
I've sent this: http://lkml.org/lkml/2007/12/15/157
Marcin
prev parent reply other threads:[~2007-12-19 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-09 21:23 [PATCH] usb/storage/initializers.c: fix signedness difference Marcin Ślusarz
2007-12-18 23:36 ` Andrew Morton
2007-12-19 18:15 ` Marcin Slusarz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071219181552.GA18104@joi \
--to=marcin.slusarz@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).