From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762733AbXLTWei (ORCPT ); Thu, 20 Dec 2007 17:34:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755729AbXLTWea (ORCPT ); Thu, 20 Dec 2007 17:34:30 -0500 Received: from xenotime.net ([66.160.160.81]:42083 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754429AbXLTWe3 (ORCPT ); Thu, 20 Dec 2007 17:34:29 -0500 Date: Thu, 20 Dec 2007 14:34:18 -0800 From: Randy Dunlap To: Andrew Morton Cc: Alan Cox , joe@perches.com, apw@shadowen.org, lizf@cn.fujitsu.com, elendil@planet.nl, linux-kernel@vger.kernel.org, tglx@linutronix.de, trivial@kernel.org, rdunlap@xenotime.net, jschopp@austin.ibm.com Subject: Re: Trailing periods in kernel messages Message-Id: <20071220143418.03696d3e.rdunlap@xenotime.net> In-Reply-To: <20071220141928.a49eba7b.akpm@linux-foundation.org> References: <474E6BD0.20103@cn.fujitsu.com> <474E8669.6060409@cn.fujitsu.com> <200711291120.19595.elendil@planet.nl> <20071129032036.4c021617.akpm@linux-foundation.org> <474F6372.70705@cn.fujitsu.com> <1196386259.22120.101.camel@localhost> <474F6D4D.9010006@cn.fujitsu.com> <1196390128.22120.118.camel@localhost> <20071220162923.GB27885@shadowen.org> <20071220210741.6dc3caf5@the-village.bc.nu> <1198186984.6183.72.camel@localhost> <20071220215411.183d03c0@the-village.bc.nu> <20071220141928.a49eba7b.akpm@linux-foundation.org> Organization: YPO4 X-Mailer: Sylpheed 2.4.7 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 20 Dec 2007 14:19:28 -0800 Andrew Morton wrote: > On Thu, 20 Dec 2007 21:54:11 +0000 > Alan Cox wrote: > > > > Documentation/Coding Style > > > > > > Chapter 13: Printing kernel messages > > > > > > Kernel messages do not have to be terminated with a period. > > > > > > This piece of the document is wrong. It should also be changed. I've no > > idea how such a ludicrous statement ever got into the Coding Style but I > > have never seen it discussed and an archive search suggests it just > > sneaked in without any kind of approval and discussion the list. > > > > Kernel messages are in English. Let us keep it that way. Missing > > punctuation is equated by many parts of the English speaking world with > > poor quality, sloppy products and low levels of education. These are not > > things with which we wish to be associated IMHO. > > > > NAK to the patch. > > akpm:/usr/src/linux-2.6.24-rc5> grep -r '[^\.]\\n"' . | wc -l > 105297 > akpm:/usr/src/linux-2.6.24-rc5> grep -r '[\.]\\n"' . | wc -l > 12743 > > For the record, I won't be taking any "add period to printk" patches. IMO if checkpatch contains a check for trailing periods, it should only be part of the strict/pedantic checks. But it's not needed. > akpm:/usr/src/linux-2.6.24-rc5> grep -r '[^\.]\\n"' net | wc -l > 4978 > akpm:/usr/src/linux-2.6.24-rc5> grep -r '[\.]\\n"' net | wc -l > 493 > > Send 'em to Dave! --- ~Randy