From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] SC26XX: New serial driver for SC2681 uarts
Date: Fri, 21 Dec 2007 17:36:01 +0000 [thread overview]
Message-ID: <20071221173601.GR13186@shadowen.org> (raw)
In-Reply-To: <20071203155317.772231f9.akpm@linux-foundation.org>
On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote:
> > +#define READ_SC(p, r) readb ((p)->membase + RD_##r)
> > +#define WRITE_SC(p, r, v) writeb ((v), (p)->membase + WR_##r)
>
> No space before the (. checkpatch misses this.
Yep, over careful in the special case for the parameters for #define
macros, which have different spacing rules. This will be fixed in 0.13:
WARNING: no space between function name and open parenthesis '('
#1: FILE: Z45.c:1:
+#define WRITE_SC(p, r, v) writeb ((v), (p)->membase + WR_##r)
-apw
prev parent reply other threads:[~2007-12-21 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-02 19:43 [PATCH] SC26XX: New serial driver for SC2681 uarts Thomas Bogendoerfer
2007-12-03 23:53 ` Andrew Morton
2007-12-03 23:57 ` Arjan van de Ven
2007-12-04 8:25 ` Thomas Bogendoerfer
2007-12-04 11:01 ` Geert Uytterhoeven
2007-12-04 12:45 ` Alan Cox
2007-12-04 23:57 ` Thomas Bogendoerfer
2007-12-04 23:41 ` Thomas Bogendoerfer
2007-12-05 3:27 ` Andrew Morton
2007-12-05 9:25 ` Thomas Bogendoerfer
2007-12-22 9:47 ` Pekka Enberg
2007-12-21 17:36 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071221173601.GR13186@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).